Coding styles, documentation and workflows#8
Conversation
The test failures were caused by a merge from dev that brought back deprecated api signatures.
|
Apologies for the noisy commit history. I ran into a few issues while preparing the PR and had to push some fixes. |
|
If everything is ok, could you also merge the code into master and generate the new release? |
|
Please don't push commits after a review is required @najirod02. |
Tonidotpy
left a comment
There was a problem hiding this comment.
Why did you remove the capacity related functionalities? The capacity is the maximum number of elements the buffer can hold while the size is the current number of elements inside the buffer at a given moment. (e.g. capacity = 10, size = 3 -> means that there are 3 items inside a buffer that can contain up to 10 items; if the size is equal to the capacity the buffer is full and cannot hold other items)
Bridiro
left a comment
There was a problem hiding this comment.
Except a few things (mainly documentation-related) seems to be working to me
|
Well, all these problems arose becasue I've made the branch starting from the main and not the dev... |
Tonidotpy
left a comment
There was a problem hiding this comment.
I'll set the version to v0.2.0 rather than v0.3.0 since this branch has not yet been merged and the only version available by now is the v0.1.0.
Except this small change the rest is ok and the PR can be approved for me.
Co-authored-by: Antonio Gelain <61268285+Tonidotpy@users.noreply.github.com>
Co-authored-by: Antonio Gelain <61268285+Tonidotpy@users.noreply.github.com>
Purpose
The library was originally developed using an outdated template and did not strictly adhere to current coding standards. This PR synchronizes the codebase with the latest library template and enforces current coding standards.
Overview
Guidance
None in particular.