32 sign off phase checks 5s rocrate

[douglowe]

Rules Implemented (so far)

#	Description	sh:Severity
1	A signed-off crate SHOULD include an AssessAction describing the result (*)	sh:Warning
2	The Root Data Entity SHOULD mention a sign-off object	sh:Warning
3	MUST provide a human-readable summary of the disclosure status (**)	sh:Violation
4	Sign-Off Phase MUST be of type AssessAction	sh:Violation
5	SHOULD be set to https://w3id.org/shp#SignOff (***).	sh:Warning
6	AssesAction SHOULD have the property schema:actionStatus	sh:Warning
7	AssessAction --> actionStatus MUST have one of the allowed values	sh:Violation
8	SHOULD have an endTime when complete or failed, with ISO format	sh:Warning
9	MAY have a startTime when active, complete, or failed, with ISO format	sh:Info
10	SHOULD include reference to the Workflow Entity as an object	sh:Warning
11	SHOULD include reference to the Responsible Project as an object	sh:Warning
12	SHOULD reference the individual/system that signed-off as an agent	sh:Warning
13	SHOULD reference the TRE policy that was signed against as an instrument	sh:Warning
14	TRE policy should be of type CreativeWork	sh:Warning
15	TRE policy should include an ID referencing the TRE policy document	sh:Warning
16	TRE policy should have a human-readable summary as name (**)	sh:Warning

(*) Implicit in rule 2, so doesn't have a dedicated SHACL rule.
(**) I've only checked for a string here. Human-readable will depend on plugging in an AI / human
(***) This rule is implicitly included in rule 2, so it does not have a dedicated SHACL implementation.

[douglowe]

I need to add to the endTime and startTime checks

[douglowe]

start and end date checks added.

[alexhambley]

I also wanted to add that for the "TRE policy should include an ID referencing the TRE policy document" rule, currently ID is not checked - we could add sh:nodeKind sh:IRI or some SPARQL as a blank node will pass I think

Obviously referencing the TRE policy document is a manual check, but we can specify at least an ID requirement?

[elichad]

with @douglowe's permission I have made the final tweaks requested, this is now ready to merge

(I copied @EttoreM's regex from this commit 586ab3d for consistency across existing PRs)