[20421] Added regresion tests for TypeIdentifier comparation #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriancampo
force-pushed
the
feature/typeidentifier_comparator
branch
from
51276ce to
fab20d4
Compare
JLBuenoLopez
approved these changes
Feb 12, 2024
Contributor
JLBuenoLopez
left a comment
JLBuenoLopez
left a comment
There was a problem hiding this comment.
LGTM. This PR needs to wait before being considered for merging.
* Refs #19906: add test case: structure inheritance with intermediate empty structure Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #19906: remove unused header Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #19906: extend Annotations.idl test cases Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #19906: fix typo Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #20129: minor fixes to pass TypeObject tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #20129: fix inherited bitset Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #20129: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
JLBuenoLopez
force-pushed
the
feature/xtypes1.3
branch
from
604460f to
049a2a3
Compare
* Refs #17138. New template for PR Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #17138. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
* Refs #20424: complete structure members Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #20424: fix union typo Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #20424: use correctly wide strings Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #20424: add structure using substructures with same name Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> --------- Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs #19451. Rebase and remove CRLR Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #19451. Add .gitattributes Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #19451. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
adriancampo
force-pushed
the
feature/typeidentifier_comparator
branch
2 times, most recently
from
fa0a545 to
da37d6f
Compare
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
Signed-off-by: adriancampo <adriancampo@eprosima.com>
adriancampo
force-pushed
the
feature/typeidentifier_comparator
branch
from
da37d6f to
eb5b513
Compare
Signed-off-by: adriancampo <adriancampo@eprosima.com>
adriancampo
force-pushed
the
feature/typeidentifier_comparator
branch
from
a4503b3 to
2defa4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: eProsima/Fast-DDS-Gen#297