fix: make ApiSpecTask compatible with Gradle Configuration Cache#297
Open
grubmeshi wants to merge 1 commit intoePages-de:masterfrom
Open
fix: make ApiSpecTask compatible with Gradle Configuration Cache#297grubmeshi wants to merge 1 commit intoePages-de:masterfrom
grubmeshi wants to merge 1 commit intoePages-de:masterfrom
Conversation
Move objectMapper instantiation from a task instance field into the @TaskAction method. Jackson's ObjectMapper contains non-serializable fields (StdDateFormat, ReentrantLock) that prevent Gradle from caching the task graph, causing 'configuration cache entry discarded' on every build that includes OpenApi3Task, OpenApiTask, or PostmanTask. Since objectMapper is only used inside aggregateResourceModels(), it does not need to be a persistent field on the task instance. Fixes ePages-de#284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
objectMapperinstantiation from a task instance field into the@TaskActionmethod to makeOpenApi3Task,OpenApiTask, andPostmanTaskcompatible with Gradle's Configuration Cache.Problem
Jackson's
ObjectMappercontains non-serializable fields (StdDateFormat,ReentrantLock) that prevent Gradle from serializing the task graph into the configuration cache. This causes:Every build that includes these tasks gets its configuration cache entry discarded, negating any caching benefit.
Fix
Since
objectMapperis only used insideaggregateResourceModels(), it does not need to be a persistent field on the task instance. Moving it to a local variable inside the@TaskActionmethod avoids the serialization issue entirely.Fixes #284