Use official connectRPC library for python env#1314
Use official connectRPC library for python env#1314matthewlouisbrockman wants to merge 19 commits intomainfrom
Conversation
…gration # Conflicts: # packages/python-sdk/poetry.lock
🦋 Changeset detectedLatest commit: 9d667ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR SummaryHigh Risk Overview This drops Reviewed by Cursor Bugbot for commit 9d667ba. Bugbot is set up for automated code reviews on this repo. Configure here. |
Package ArtifactsBuilt from bac46a3. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.19.6-python-connect-rpc-migration.0.tgzCLI ( npm install ./e2b-cli-2.10.2-python-connect-rpc-migration.0.tgzPython SDK ( pip install ./e2b-2.21.0+python.connect.rpc.migration-py3-none-any.whl |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a60552436
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8522c9e to
47facc0
Compare
|
alright, the bots are picking up on a ton of things that are clearly not in the test coverage... so i guess it's really want to fix the test coverage |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0a551a1. Configure here.

migrates python envd RPC generation to the official Connect RPC python plugin (js already uses the equivalent)
keeps packages/connect-python for now to avoid the codeql complaint, can remove that later as standalone.
main thing here: we got more tests in, but it doesn't have support for the proxy behavior we have so we needed to write a httpx wrapper instead of pyqwest so it may just defeat the purpose of using the real library.