-
Notifications
You must be signed in to change notification settings - Fork 877
fix(js-sdk): skip test when E2B_API_KEY is not set (fixes Copilot feedback on PR #1224) #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
passionworkeer
wants to merge
5
commits into
e2b-dev:main
from
passionworkeer:fix/copilot-review-test-flakiness
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1d09def
fix: add read/write timeouts for server stream requests
passionworkeer 4d3d200
fix: update pause() JSDoc and add apiKey propagation regression test
b9d1c65
fix: propagate connectionConfig to pause() and betaPause() methods
penggaolai f8ad6f4
fix(js-sdk): skip test when E2B_API_KEY is not set and fix misleading…
293adba
fix: address Copilot feedback - use proper test skip and update PR scope
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description focuses on JS SDK test/comment fixes, but this change also modifies Python SDK streaming request timeout behavior by adding
read/writetimeouts. Please either update the PR description to mention the Python change (and rationale/impact), or split it into a separate PR to keep scope clear.