Skip to content

fix(sandbox): enhance pause method to merge connection config with options#1216

Closed
OpeOginni wants to merge 1 commit intoe2b-dev:mainfrom
OpeOginni:fix/let-pause-command-inherit-connect-opts
Closed

fix(sandbox): enhance pause method to merge connection config with options#1216
OpeOginni wants to merge 1 commit intoe2b-dev:mainfrom
OpeOginni:fix/let-pause-command-inherit-connect-opts

Conversation

@OpeOginni
Copy link

Updated the pause method in the Sandbox class to merge the existing connectionConfig with the provided options (opts). This change ensures that connection settings are consistently applied when pausing the sandbox, improving flexibility and usability. Just like it is for the kill method.

Fixes #1215

Please ignore and close if this behaves like so on purpose.

…tions

Updated the `pause` method in the `Sandbox` class to merge the existing `connectionConfig` with the provided options (`opts`). This change ensures that connection settings are consistently applied when pausing the sandbox, improving flexibility and usability.
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2026

⚠️ No Changeset found

Latest commit: 66bb899

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mishushakov
Copy link
Member

Hey, just fyi. we're already working on a fix here:
#1179

@OpeOginni OpeOginni closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Passed Credential in Sandbox.connect, does not get used in .pause method like in .kill

2 participants