Skip to content

chore(cli): tighten up sandbox exec piping tests#1129

Open
matthewlouisbrockman wants to merge 11 commits intomainfrom
piping-tone-down-the-tests-configs-eng-3497
Open

chore(cli): tighten up sandbox exec piping tests#1129
matthewlouisbrockman wants to merge 11 commits intomainfrom
piping-tone-down-the-tests-configs-eng-3497

Conversation

@matthewlouisbrockman
Copy link
Contributor

@matthewlouisbrockman matthewlouisbrockman commented Feb 13, 2026

  • refactors the CLI tests to better follow the js sdk patterns

following up from comments on #1127


Note

Low Risk
Mostly test refactoring and shared helpers; production change is a small error-path tweak to ensure remote processes are killed if stdin EOF signaling fails.

Overview
Refactors sandbox CLI integration tests to use a shared tests/setup.ts harness (runCli, runCliWithPipedStdin, env/timeout helpers) and simplifies skip logic (skip only when E2B_DEBUG is set). The backend integration tests are streamlined (looped logs/metrics, centralized CLI invocation), and the exec piping integration test now probes stdin capability before asserting byte counts to reduce flakiness in environments where piped stdin isn’t detected.

In sandbox exec, the stdin EOF failure path is simplified by inlining the best-effort remote kill and removing the helper function, keeping the “fail fast to avoid leaking a blocked process” behavior.

Written by Cursor Bugbot for commit f352196. This will update automatically on new commits. Configure here.

@linear
Copy link

linear bot commented Feb 13, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

⚠️ No Changeset found

Latest commit: f352196

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 045cf19a96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@matthewlouisbrockman matthewlouisbrockman changed the title chore(cli): tighten up sandbox exec piping chore(cli): tighten up sandbox exec piping tests Feb 13, 2026
@matthewlouisbrockman matthewlouisbrockman added the cli Improvements or additions to CLI label Feb 16, 2026
@matthewlouisbrockman
Copy link
Contributor Author

uh oh

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

Package Artifacts

Built from c928859. Download artifacts from this workflow run.

JS SDK (e2b@2.14.2-piping-tone-down-the-tests-configs-eng-3497.0):

npm install ./e2b-2.14.2-piping-tone-down-the-tests-configs-eng-3497.0.tgz

CLI (@e2b/cli@2.8.2-piping-tone-down-the-tests-configs-eng-3497.0):

npm install ./e2b-cli-2.8.2-piping-tone-down-the-tests-configs-eng-3497.0.tgz

Python SDK (e2b==2.15.2+piping-tone-down-the-tests-configs-eng-3497):

pip install ./e2b-2.15.2+piping.tone.down.the.tests.configs.eng.3497-py3-none-any.whl

@ValentaTomas ValentaTomas removed their request for review March 12, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Improvements or additions to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants