chore(cli): tighten up sandbox exec piping tests#1129
chore(cli): tighten up sandbox exec piping tests#1129matthewlouisbrockman wants to merge 11 commits intomainfrom
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 045cf19a96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
uh oh |
Package ArtifactsBuilt from c928859. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.14.2-piping-tone-down-the-tests-configs-eng-3497.0.tgzCLI ( npm install ./e2b-cli-2.8.2-piping-tone-down-the-tests-configs-eng-3497.0.tgzPython SDK ( pip install ./e2b-2.15.2+piping.tone.down.the.tests.configs.eng.3497-py3-none-any.whl |
following up from comments on #1127
Note
Low Risk
Mostly test refactoring and shared helpers; production change is a small error-path tweak to ensure remote processes are killed if stdin EOF signaling fails.
Overview
Refactors sandbox CLI integration tests to use a shared
tests/setup.tsharness (runCli,runCliWithPipedStdin, env/timeout helpers) and simplifies skip logic (skip only whenE2B_DEBUGis set). The backend integration tests are streamlined (loopedlogs/metrics, centralized CLI invocation), and the exec piping integration test now probes stdin capability before asserting byte counts to reduce flakiness in environments where piped stdin isn’t detected.In
sandbox exec, the stdin EOF failure path is simplified by inlining the best-effort remotekilland removing the helper function, keeping the “fail fast to avoid leaking a blocked process” behavior.Written by Cursor Bugbot for commit f352196. This will update automatically on new commits. Configure here.