Potential Fix to Improve Script #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
Jan 22, 2026
| # Build and other measurements + generate stats | ||
| generate-stats: | ||
| needs: [setup, measure-install] | ||
| if: always() && needs.setup.result == 'success' |
Contributor
There was a problem hiding this comment.
does this need the always()?
43081j
approved these changes
Jan 22, 2026
Contributor
43081j
left a comment
43081j
left a comment
There was a problem hiding this comment.
much cleaner! 🎉
looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having to add a new step into the CI every time you add a new package (as there will be a few), I have rewritten the CI to work off a
package.jsonAs we may end up with different packages, for example starter or a full app for testing other stats, I have also added an array to control which tests you run for each entry.
As it is all run on merge to main, I need to merge to fully test sigh lol I might create a special script that runs in the PR and commits to the PR when making changes to CI to test it mostly works (apart from the commit PR part)