fix: handle missing name/version in package.json #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When analyzing monorepos, the root package.json may not have name or version fields, causing a crash in the analyze command. This adds fallback values consistent with computeInfo().
43081j
reviewed
Jan 21, 2026
src/analyze/report.ts
Outdated
| name: packageFile.name, | ||
| version: packageFile.version, | ||
| name: packageFile.name || 'unknown', | ||
| version: packageFile.version || 'unknown', |
Contributor
There was a problem hiding this comment.
we should probably default it to a valid semantic version at least, maybe 0.0.0.
just in case in future we try parse the version
Contributor
Author
|
Fixed - now defaults to |
43081j
approved these changes
Jan 21, 2026
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When analyzing monorepos (e.g., LangChain.js), the root
package.jsonmay not havenameorversionfields. This causes theanalyzecommand to crash with:This PR adds fallback values (
'unknown') consistent with howcomputeInfo()already handles this case (lines 34-35 in the same file).Test plan