Use per-fraction reference doses in quality indicators#909
Open
acsevillam wants to merge 1 commit into
Open
Conversation
1 task
wahln
requested changes
Jun 2, 2026
Contributor
wahln
left a comment
wahln
left a comment
There was a problem hiding this comment.
This is also quite nice, but I would expand a bit on the detection of objectives / constraints as suggested in the line comment.
Comment on lines
+79
to
+81
| isUnderdoseObjective = isa(obj, 'DoseObjectives.matRad_SquaredDeviation') || ... | ||
| isa(obj, 'DoseObjectives.matRad_SquaredUnderdosing') || ... | ||
| isa(obj, 'DoseObjectives.matRad_MinDVH'); |
Contributor
There was a problem hiding this comment.
Here you could also check for Constraints (on Dose, maybe DVH. EUD might also be okay (with negative exponent)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
This PR ports the fix proposed in #904 to the current
devbranch.Quality indicators could mix per-fraction dose cubes with total prescription/objective doses in plan analysis paths.
Approach
This PR keeps canonical quality indicators in per-fraction dose units and adds explicit conversion helpers for display/evaluation in total dose when requested.
Validation
matRad_runTests('test/planAnalysis/test_calcQualityIndicators.m')matRad_runTests('test/planAnalysis')mh_metricmh_stylemh_lint