Implementation of multi alpha/beta for proton plans with TOPAS#884
Implementation of multi alpha/beta for proton plans with TOPAS#884
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #884 +/- ##
==========================================
+ Coverage 54.80% 54.91% +0.11%
==========================================
Files 310 310
Lines 20040 20115 +75
==========================================
+ Hits 10982 11046 +64
- Misses 9058 9069 +11 ☔ View full report in Codecov by Sentry. |
wahln
left a comment
There was a problem hiding this comment.
To me, this looks really great. I will run a Copilot Review to see if there's anything substantial it catches.
Is there anything we could do do get more test coverage? For TOPAS, we only check if the files are written I think.
There was a problem hiding this comment.
Pull request overview
Enables Monte Carlo (TOPAS) proton plan recalculation with multiple structure-dependent photon LQ parameters (α/β), introducing “CellType” variants of TOPAS RBE scorers and partial postprocessing support.
Changes:
- Extend TOPAS MC engine to derive multiple (αx, βx) pairs from
cstand emit per-CellType scorer variants. - Update RBExDose parameter initialization and begin mapping scorer outputs back into
dijper CellType. - Prevent zero-width dose-difference display range in
matRad_compareDose.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
matRad/planAnalysis/matRad_compareDose.m |
Avoids invalid [0 0] dose-difference display window when cubes are identical. |
matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m |
Adds multi-(α/β) handling for TOPAS proton RBE scorers and attempts CellType-aware readback into dij. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…m/SimonaFa/matRad into dev_TOPASinterface_multiAlphaBeta
Tolerance for assertElementsAlmostEqual needs to be increased.
- Order of alpha/beta couples: stabilized - TopasMCEngine test: passed
First concept for enabling a Monte Carlo recalculation using different alpha/beta for different structures. The implementation works for protons when using the default TOPAS scorers (MCN, WED), but needs to be extended for carbon in the future, to include the tabulated models which are currently not available on this branch.