feat: 🎸 edit project configuration

[amanecer2levi]

✅ Closes: 15

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 15

What is the new behavior?

Edit project configuration

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

[nx-cloud]

Nx Cloud Report

CI is running for commit 199e799.

📂 Click to track the progress, see the status, the terminal output, and the build insights.

---

Sent with 💌 from NxCloud.

[Danieliverant]

I resolved what you fixed and reviewed again, please see my previous review comments

[ronnetzer]

why is it needed? I didnt see that you import json anywhere, if its for jest, move it to tsconfig.spec.json

[amanecer2levi]

im importing angular.json file.

[ronnetzer]

Suggested change

	this.workspaceSettingsService
	.updateWorkspaceProjectConfiguration(
	this.projectName,
	this.form.value as Project
	)
	.subscribe();
	this.projectName$.pipe(
	take(1),
	switchMap(projectName =>
	this.workspaceSettingsService
	.updateWorkspaceProjectConfiguration(
	projectName,
	this.form.value as Project
	)
	)
	).subscribe();

then you can remove this.projectName and the tap that assigns its value

[ronnetzer]

Suggested change

	readonly formly$: Observable<{
	formData: JsonObject;
	formFields: FormlyFieldConfig[];
	}> = combineLatest([this.formData$, this.formFields$]).pipe(
	map(([formData, formFields]) => ({ formFields, formData }))
	);
	readonly formly$: Observable<{
	formData: JsonObject;
	formFields: FormlyFieldConfig[];
	}> = combineLatest([this.projectConfiguration$, this.workspaceProject$]).pipe(
	map(([formFields, formData]) => ({ formFields, formData }))
	);

then you can remove formFields$ and formData$ subjects and ngOnInit completely

[ronnetzer]

Suggested change

	)
	),
	distinctUntilChanged()

[ronnetzer]

Suggested change

	tap((projectName) => (this.projectName = projectName))
	distinctUntilChanged()

[ronnetzer]

if observables are being subscribed in more than once place you should also add shareReplay({ bufferSize: 1, refCount: true }) operator at the end, in order to avoid multiple subscriptions to the source

[Danieliverant]

Looks good to me, just a small question - have we decided to go with Formly? why not plain reactive-forms?

[Danieliverant]

why this import is from 'node_modules' and not from @angular/cli like the others?

[ronnetzer]

This file should be read in runtime. Currently you're bundling & reading our installed angular pkg, instead you need to read the installed angular pkg in the currently active user's workspace by using node's fs module (readFile, readFileSync).

After this change you can revert the changes you made in the tsconfig file