This repository was archived by the owner on Nov 29, 2022. It is now read-only.
Fix an issue that causes gestures not reaching the emptyDataSetView on iOS 7 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a `indexForEmptyDataSetView` method to encapsulate the logic that figures out where to insert the `DZNEmptyDataSetView` in the `UIScrollView` subviews hierarchy. Figuring out the proper index is moderately complex because it needs some decision making based on the `UIScrollView`s actual class and the current iOS version.
Owner
|
Thanks for this, and sorry for such a late reply. This PR is now unable to merge automatically, and I wasn't very sure about it either. I wonder if there is a simpler approach for this. |
Contributor
Author
|
New fix suggested in #126 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a
indexForEmptyDataSetViewmethod to encapsulate the logic that figures out where to insert theDZNEmptyDataSetViewin theUIScrollViewsubviews hierarchy.Figuring out the proper index is moderately complex because it needs some decision making based on the
UIScrollViews actual class and the current iOS version.This is a fix for #47