This repository was archived by the owner on Nov 29, 2022. It is now read-only.
Kellyroach/fix warnings #411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etailViewController, remove deprecated code, fix bugs, fix tests.
…path Search Paths' and snapshots, .travis.yml
…ceOrientationPortraitUpsideDown
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the Applications and Colors demo apps of DZNEmptyDataSet to Xcode 9.4.1 modern *.storyboard's with autolayout, removing deprecated code, fixing 2 broken tests, fixing bugs in the demo apps. UISearchDisplayController is marked Deprecated by Apple. We've replaced this with newer UISearchBar and UISearchController . The old SearchViewController in the Colors demo app was being used two different ways. We've split this up into SearchViewController and DetailViewController .
We believe our P.R. subsumes #401, #395, #392 regarding the retain cycle warning in
UIScrollView+EmptyDataSet.m .
We've reviewed other outstanding P.R.'s. We feel the remaining recent P.R.'s, especially
wrt UIScrollView+EmptyDataSet.m and contentView are independent of our P.R.
UPDATE: We've updated this pull request to Xcode 10 .