-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix false origin y of emptyDataSet view when scrollview had been scrolled #182
base: master
Are you sure you want to change the base?
Conversation
|
Hi! I'm having the same issue and this PR fixes it. So +1 for merge. P.S. |
|
Hi! |
|
@marcelmika: maybe we can add the view and adjust the frame inside of a |
|
@dzenbot Anything preventing this PR getting merge? Just tested it and it fixed the issue for me. Thanks for your time 🍺 |
|
@dzenbot is there anything preventing this PR from being merged? |
|
@benrudhart: I was mostly concerned about #182 (comment) |
|
@dzenbot Yes, since it's minor, we could tackle this in a different PR, absolutely. Cheers! |
|
vote for merge +1. For people who has the same issue, there is a way to walk around it by calling self.tableView.setContentOffset(CGPointZero, animated:false) before reload the tableView. This will scroll to the top of the tableView, hence prevent the EmptyDataSet being off the screen |
|
Other possible solution:
|
|
I'm having the same issue, please tell me how to do |
after scrolling a tableView and re-showing the emptyDataSet the offset (within a tableView) won't be fixed but adjusted to the scrollView's Y contentOffset.
This PR fixes this.