Skip to content

🔒 Fix Potential Shell Command Injection in PDF Conversion Script #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dynamikdev wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

🔒 Fix Potential Shell Command Injection in PDF Conversion Script #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions scripts/convert_pdfs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,16 @@ find "$BASE_DIR" -type f -name "*.pdf" | while read -r pdf_file; do

# Rename pages to have leading zeros for better sorting (page-1.jpg -> page-01.jpg)
for f in "$output_dir"/page-*.jpg; do
# Extract the number, strip any leading dash and the .jpg extension
num=$(basename "$f" .jpg | sed 's/page-//')
# Check if the file exists (handles the case where no files match the glob)
[ -e "$f" ] || continue

# Extract the number securely using bash parameter expansion
base="${f##*/}"
base="${base%.jpg}"
num="${base#page-}"

# Remove leading zero to avoid octal interpretation in bash printf
clean_num=$(echo $num | sed 's/^0*//')
clean_num="${num#"${num%%[!0]*}"}"
# If the number was 0 or 00, clean_num might be empty
if [ -z "$clean_num" ]; then clean_num=0; fi

Expand Down