Bail ASI loop when inner expr() does not advance the cursor#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A switch body with multi-statement case branches throws
RangeError: Invalid array lengthwhile parsing:Trace: infinite recursion through
asi → expr → asi → expr …until the semicolon-list array overflows. The ASI loop continues whenever the innerexpr()returns truthy, but a lookup handler is allowed to return a non-array sentinel to mean "matched but did not consume" —feature/switch.js'sreserve('case')does this whencase/defaultappears inside a switch body, so ASI re-enters at the same cursor position.Bail when the recursive
expr()returns truthy without advancingidx. Regression test intest/feature/control.js. Suite stays green (294/294).