Skip to content

Conversation

@RITIK-CHAUDHRY
Copy link

add leaderboard to the mobile phones resolved issue #17

@netlify
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for computercodingtest ready!

Name Link
🔨 Latest commit 3b2c2c7
🔍 Latest deploy log https://app.netlify.com/sites/computercodingtest/deploys/677f682b6c874d0008363b10
😎 Deploy Preview https://deploy-preview-57--computercodingtest.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dwargosama
Copy link
Owner

dwargosama commented Jan 9, 2025

The route for leaderboard is changed from 'leader-board' to 'leaderboard'. hamburger and nabber's leader board button directs to different routes. The button in ham-burger menu is directing to route 'leaderboard' and the navbar in desktop view is directing to route 'leader-board'. Unable to access leaderboard in desktop mode.

Please change 'leaderboard' to 'leader-board' in:

  1. client-side/src/App.js (Line: 42)
  2. client-side/src/components/NavBar/HamBurgerMenu.jsx (Line: 181)

@RITIK-CHAUDHRY
Copy link
Author

RITIK-CHAUDHRY commented Jan 9, 2025

@adityarai0705 i have made PR but sir actually after implementing changes when i am trying to check them in web because of localhost i am unable to login can you suggest a way please

@MrinalVarshney
Copy link
Collaborator

MrinalVarshney commented Jan 9, 2025

@RITIK-CHAUDHRY
Have you configured the environment variables correctly for both the client and server?

If not, please refer to the dummy_env file in the server-side directory and the env file in the client-side directory to set all environment variables correctly.

Once configured, try registering using your localhost setup for both the client and server. Let me know if you encounter any issues!

@CoderFleet
Copy link
Contributor

@adityarai0705 i have made PR but sir actually after implementing changes when i am trying to check them in web because of localhost i am unable to login can you suggest a way please

@RITIK-CHAUDHRY
Umm.. There's a little trick to that which I realised while working: You can change auth && () snippet to true && () while working this way you will be able to access logged in state of the Navbar without actually setting up backend locally to login

@dwargosama
Copy link
Owner

@RITIK-CHAUDHRY , please create PR for branch 'version-1.2' instead of 'main'.

@dwargosama
Copy link
Owner

dwargosama commented Jan 10, 2025

@RITIK-CHAUDHRY , do you have any update?

@RITIK-CHAUDHRY
Copy link
Author

sir give me time till tommorow night i actually caught up with cold. I will make the PR of all my assigned ones tommorow

@dwargosama
Copy link
Owner

@RITIK-CHAUDHRY,
Np, take your time, it's not that urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants