Skip to content

Update comments to indicate visual_style param as deprecated #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronAtDuo merged 2 commits into from
Feb 11, 2025
Merged

Update comments to indicate visual_style param as deprecated #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d59568
update comments to indicate visual_style param as deprecated
DenitsaTH Feb 11, 2025
6eec344
update Python versions in CI (#284)
DenitsaTH Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]

steps:
- name: Checkout
Expand Down
11 changes: 4 additions & 7 deletions duo_client/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,9 @@
'notes': <str:notes>,
'secret_key': <str:secret key>,
'type': <str:integration type>,
'visual_style': <str:visual style>}
'visual_style': Deprecated; ignored if specified.}

See the adminapi docs for possible values for enroll_policy, visual_style, ip_whitelist,
and type.
See the adminapi docs for possible values for enroll_policy, ip_whitelist, and type.


ADMINISTRATIVE UNITS
Expand Down Expand Up @@ -2599,8 +2598,7 @@ def create_integration(self,
name - The name of the integration (required)
integration_type - <str: integration type constant> (required)
See adminapi docs for possible values.
visual_style - <str:visual style constant> (optional, default 'default')
See adminapi docs for possible values.
visual_style - Deprecated; ignored if specified.
greeting - <str:Voice greeting> (optional, default '')
notes - <str:internal use> (optional, uses default setting)
enroll_policy - <str:'enroll'|'allow'|'deny'> (optional, default 'enroll')
Expand Down Expand Up @@ -2799,8 +2797,7 @@ def update_integration(self,

integration_key - The key of the integration to update. (required)
name - The name of the integration (optional)
visual_style - (optional, default 'default')
See adminapi docs for possible values.
visual_style - Deprecated; ignored if specified.
greeting - Voice greeting (optional, default '')
notes - internal use (optional, uses default setting)
enroll_policy - <'enroll'|'allow'|'deny'> (optional, default 'enroll')
Expand Down