-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Cur2 1199 dex daily volume #9170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…view to share with client
PR SummaryIntroduces chain-scoped, incremental daily token volume computation and a unified cross-chain view.
Written by Cursor Bugbot for commit 88755c6. Configure here. |
|
Ready for review - data quality checks here: https://linear.app/dune/issue/CUR2-1199/create-dextoken-volume-day-table-for-consensys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
tomfutago
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @alicecha - just added a few minor comments
dbt_subprojects/dex/models/trades/abstract/dex_abstract_token_volumes_daily.sql
Outdated
Show resolved
Hide resolved
| , CASE WHEN bought_volume_raw_sum IS NULL AND sold_volume_raw_sum IS NULL THEN NULL | ||
| ELSE COALESCE(bought_volume_raw_sum, 0) + COALESCE(sold_volume_raw_sum, 0) | ||
| END AS volume_raw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just this instead of CASE..WHEN?
NULLIF(COALESCE(bought_volume_raw_sum, 0) + COALESCE(sold_volume_raw_sum, 0), 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is I would like it to default to NULL if both supply and bought are NULL
jeff-dude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proactive approval, but agree with tom feedback on macro usage.
Co-authored-by: alice.chaverot <alice.chaverot@dune.com>
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: