You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the action button text on the YouTube ad blocking Next Steps card from "Open YouTube" to "Visit YouTube". Applies to both the next-steps and next-steps-list variants. The compiled public/locales/en/new-tab.json is regenerated from the source strings.json files.
Testing Steps
Open the New Tab page and find the YouTube ad blocking Next Steps card (both the next-steps and next-steps-list variants).
Confirm the action button reads "Visit YouTube".
Checklist
Please tick all that apply:
I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged
Note
Low Risk
Low risk copy-only localization updates; no logic changes, data handling, or security impact.
Overview
Updates the YouTube ad-blocking Next Steps CTA text from "Open YouTube" to "Visit YouTube" for both next-steps and next-steps-list.
Regenerates the corresponding localized strings in public/locales/*/new-tab.json (including English and multiple translated locales) to reflect the updated button label.
Reviewed by Cursor Bugbot for commit 592d24e. Bugbot is set up for automated code reviews on this repo. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Web Compatibility Assessment
No findings. The diff is limited to English string literal changes for the YouTube ad-blocking next-step CTA in special-pages/pages/new-tab/app/next-steps-list/strings.json, special-pages/pages/new-tab/app/next-steps/strings.json, and special-pages/pages/new-tab/public/locales/en/new-tab.json. It does not change injected runtime behavior, API wrapping/shimming, DOM manipulation, config gating, or platform entry points.
Security Assessment
No findings. The PR does not touch injected/src, wrapper utilities, messaging transports, message bridge code, captured globals, network calls, iframe handling, or any trust-boundary logic.
Risk Level
Low Risk: string-only Special Pages localization update with matching source catalog and English locale changes.
Recommendations
No blocking recommendations. I validated the modified JSON parses cleanly and git diff --check reports no whitespace issues.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Web Compatibility Assessment
No findings. The current diff is limited to source catalog and locale string changes for the YouTube ad-blocking Next Step CTA in special-pages/pages/new-tab/.... The existing data wiring still reads the same nextStepsList_youtubeAdBlocking_actionText and nextSteps_youtubeAdBlocking_actionText keys; only displayed text changes from “Open YouTube” to “Visit YouTube” equivalents.
Security Assessment
No findings. This PR does not touch injected/src, wrapper utilities, captured globals, messaging transports, message bridge code, DOM manipulation, network calls, iframe handling, or trust-boundary logic.
Risk Level
Low Risk: localization-only Special Pages update with no injected runtime behavior or API-surface changes.
Recommendations
No blocking recommendations. I validated that all 11 changed JSON files parse cleanly and git diff --check reports no whitespace issues.
The reason will be displayed to describe this comment to others. Learn more.
Web Compatibility Assessment
No findings. The current diff is limited to New Tab localization strings for the existing YouTube ad-blocking Next Step CTA keys (nextStepsList_youtubeAdBlocking_actionText and nextSteps_youtubeAdBlocking_actionText). The existing data wiring still reads the same keys and the PR does not change action IDs, native message payloads, DOM behavior, injected runtime code, API wrappers, or platform entry points.
Security Assessment
No findings. The PR does not touch injected/src, wrapper utilities, captured globals, messaging transports, message bridge code, network calls, iframe handling, config trust boundaries, or any page-world security-sensitive logic.
Risk Level
Low Risk: localization-only Special Pages copy update with no injected runtime or browser API surface changes.
Recommendations
No blocking web compatibility or security recommendations. I validated that all 11 changed JSON files parse cleanly, both affected CTA keys remain in sync within each locale, and git diff --check reports no whitespace issues. I did not add an inline comment for the Russian wording because an existing Bugbot thread already tracks that non-security copy consistency issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semver-patchBug fix / internal — no release needed
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
daxtheduck
dismissed
their stale review
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/38424471409662/task/1214934618730802?focus=true
Description
Updates the action button text on the YouTube ad blocking Next Steps card from "Open YouTube" to "Visit YouTube". Applies to both the
next-stepsandnext-steps-listvariants. The compiledpublic/locales/en/new-tab.jsonis regenerated from the sourcestrings.jsonfiles.Testing Steps
next-stepsandnext-steps-listvariants).Checklist
Please tick all that apply:
Note
Low Risk
Low risk copy-only localization updates; no logic changes, data handling, or security impact.
Overview
Updates the YouTube ad-blocking Next Steps CTA text from "Open YouTube" to "Visit YouTube" for both
next-stepsandnext-steps-list.Regenerates the corresponding localized strings in
public/locales/*/new-tab.json(including English and multiple translated locales) to reflect the updated button label.Reviewed by Cursor Bugbot for commit 592d24e. Bugbot is set up for automated code reviews on this repo. Configure here.