Skip to content

build(deps-dev): bump the typescript group across 1 directory with 4 updates #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

build(deps-dev): bump the typescript group across 1 directory with 4 updates #2602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions injected/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
"@canvas/image-data": "^1.1.0",
"@duckduckgo/privacy-reference-tests": "github:duckduckgo/privacy-reference-tests#c2b49fe7ce4a75404c6a79e4dd1053710a9869ee",
"@fingerprintjs/fingerprintjs": "^5.2.0",
"@types/chrome": "^0.1.37",
"@types/chrome": "^0.1.42",
"@types/jasmine": "^6.0.0",
"@types/node": "^25.5.0",
"@types/node": "^25.6.2",
"@types/seedrandom": "^3.0.8",
"c8": "^11.0.0",
"fast-check": "^4.6.0",
Expand Down
153 changes: 90 additions & 63 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"stylelint-config-standard": "^40.0.0",
"stylelint-csstree-validator": "^4.0.0",
"ts-json-schema-generator": "^2.5.0",
"typedoc": "^0.28.17",
"typescript": "^5.9.3",
"typedoc": "^0.28.19",
"typescript": "^6.0.3",
Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TS major bump is currently incompatible with typescript-eslint@8.57.2 (still peers typescript <6.0.0), which causes npm ci to fail with ERESOLVE before tests run. Recommend pairing this with a typescript-eslint bump to a TS6-compatible release (e.g., 8.58.2).

Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping typescript to ^6.0.3 is currently causing reproducible CI breakage in this repo’s existing TS config surface (notably TS5107 deprecation on moduleResolution=node10 path and missing global test types under TS6 default behavior). Recommend either pinning TS back to 5.9.x in this PR or landing a separate TS6 migration PR first (explicit types + module resolution migration).

Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping to typescript@^6.0.3 is currently breaking required CI in this repo (lint/docs/type-check paths). Evidence on this PR includes TS5107 (moduleResolution=node10 deprecation) plus broad TS diagnostics in docs/type-check jobs. Recommend splitting: keep typedoc + @types/* bumps here, and run TS6 migration in a dedicated follow-up PR with tsconfig and JSDoc typing fixes.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TypeScript 6 bump currently breaks the root typecheck: npm run tsc fails with TS5107 because tsconfig.json still uses moduleResolution: "node"/node10 without ignoreDeprecations: "6.0". Please either migrate the module resolution mode deliberately or add the TS 6 deprecation opt-out before merging.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TS 6 bump currently breaks the root checks. With this PR installed, npm run tsc fails immediately with TS5107 because tsconfig.json still has "moduleResolution": "node" (node10), which the TS 6 release notes mark as deprecated/erroring unless explicitly ignored. If I force past that with --ignoreDeprecations 6.0, the TS 6 default changes then expose 3,219 diagnostics, mostly because strict now defaults to true and types now defaults to [] while this repo does not explicitly pin either. npm run docs fails similarly through TypeDoc. After npm run build-surrogates -w injected, the TS 5.9 compiler passes on the same checkout, so this is a regression from the compiler update rather than a pre-existing generated-file issue.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TS 6 bump currently breaks the root typecheck. With this diff applied, npm run tsc fails:

tsconfig.json(5,25): error TS5107: Option 'moduleResolution=node10' is deprecated and will stop functioning in TypeScript 7.0. Specify compilerOption '"ignoreDeprecations": "6.0"' to silence this error.

Because npm run lint chains npm run tsc, this should be addressed as part of the dependency bump, either by migrating the module resolution setting or explicitly adding "ignoreDeprecations": "6.0" if keeping the current behavior is intentional.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript 6.0 breaks build: moduleResolution: "node" deprecated

High Severity

Bumping typescript from 5.9.3 to 6.0.3 is a major version upgrade. TypeScript 6.0 deprecates moduleResolution: "node" with a hard error (not just a warning). The project's tsconfig.json uses "moduleResolution": "node" and has no ignoreDeprecations setting. This will cause tsc to fail, breaking npm run lint which runs tsc as part of its pipeline. Either tsconfig.json needs to switch to "moduleResolution": "bundler" (or "nodenext"), or "ignoreDeprecations": "6.0" needs to be added.

Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8b5e29c. Configure here.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript 6.0 types default change breaks test type-checking

High Severity

TypeScript 6.0 changes the default types from auto-including all @types packages to []. The project's tsconfig.json doesn't specify types, so @types/jasmine, @types/chrome, and @types/node globals will no longer be available. Test files (e.g., in injected/unit-test/) use Jasmine globals like describe and it without explicit imports, which will produce type errors under the new default.

Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8b5e29c. Configure here.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript 6.0 strict default enables noImplicitAny on JS files

High Severity

TypeScript 6.0 changes strict to default to true. The project's tsconfig.json never sets strict, noImplicitAny, or other strict sub-flags (only strictNullChecks). With allowJs: true and checkJs: true, the newly-enabled noImplicitAny will flag every JS function parameter lacking a JSDoc type annotation. This would produce a large number of new type errors when running tsc. The fix is to add "strict": false to tsconfig.json or explicitly disable the individual sub-flags that aren't wanted.

Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8b5e29c. Configure here.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: this TypeScript 6 bump needs a matching tsconfig.json migration. TypeScript 6 errors on the current moduleResolution: "node" setting (TS5107) and also changes defaults for strict and types; PR-head npm run tsc and npm run docs fail locally, and CI docs-preview shows the same class of failures. I opened a separate fix PR at #2695.

"typescript-eslint": "^8.59.1"
},
"dependencies": {
Expand Down
Loading