Add experiment toggle for the quick setup on the new onboarding#8523
Open
catalinradoiu wants to merge 5 commits into
Open
Add experiment toggle for the quick setup on the new onboarding#8523catalinradoiu wants to merge 5 commits into
catalinradoiu wants to merge 5 commits into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cb15ce0. Configure here.
4 tasks
| * cohort should be shown the quick-setup screen during onboarding. | ||
| */ | ||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) | ||
| @Experiment |
Contributor
There was a problem hiding this comment.
Remove @Experiment, you don't need this unless is an atb experiment
| */ | ||
| @Toggle.DefaultValue(DefaultFeatureValue.FALSE) | ||
| @Experiment | ||
| fun quickSetup(): Toggle |
Contributor
There was a problem hiding this comment.
I think the name should be quickSetupExperimentMay26 so we all know this is an experiment and when it's going to run
Contributor
Author
There was a problem hiding this comment.
Renamed to onboardingQuickSetupExperimentMay26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:https://app.asana.com/1/137249556945/project/1211724162604201/task/1214705898682649?focus=true
Description
Adds a new A/B test feature toggle
quickSetup()toOnboardingBrandDesignUpdateTogglesto gate the re-installer quick-setup screen during onboarding. The toggle is annotated as an@Experimentand includes two cohorts —CONTROLandTREATMENT— where only users assigned to theTREATMENTcohort will be shown the quick-setup screen.Create
OnboardingQuickSetupExperimentManagerthat assings the user to a cohort and returns the assigned experiment variant.Steps to test this PR
CI passes
UI changes
No UI changes
Note
Low Risk
Low risk: adds new remote feature/experiment toggles and a small enrollment helper with defaults disabled; behavior changes only when the experiment is enabled remotely.
Overview
Adds a new remote feature toggle set
OnboardingQuickSetupTogglesfor onboarding quick-setup, including anonboardingQuickSetupExperimentMay26A/B experiment withcontrolandtreatmentcohorts (default disabled).Introduces
OnboardingQuickSetupExperimentManager(AppScope DI binding) to enroll users into that experiment on an IO dispatcher and return the assigned variant (CONTROL/TREATMENT) ornullwhen not enrolled.Reviewed by Cursor Bugbot for commit ca36215. Bugbot is set up for automated code reviews on this repo. Configure here.