Skip to content

Onboarding Brand Design Update: Update welcome screen copy#8515

Draft
mikescamell wants to merge 1 commit into
feature/mike/onboarding-brand-design-updates/default-browserfrom
onboarding-design-update-copy-changes
Draft

Onboarding Brand Design Update: Update welcome screen copy#8515
mikescamell wants to merge 1 commit into
feature/mike/onboarding-brand-design-updates/default-browserfrom
onboarding-design-update-copy-changes

Conversation

@mikescamell
Copy link
Copy Markdown
Contributor

@mikescamell mikescamell commented May 11, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1213611375324061?focus=true

Description

Splits the welcome screen body copy into two text views so the new two-sentence wording renders with consistent spacing between lines. Hides the second body line when the welcome dialog transitions into the skip-onboarding screen so its copy doesn't bleed through.

Steps to test this PR

Welcome screen copy

  • Launch the app on a fresh install with the brand-design onboarding enabled
  • Verify the welcome dialog title is followed by two distinct body lines, both fading in together
  • Verify the new copy reads correctly across portrait and landscape

Skip-onboarding transition

  • Tap the secondary (skip) button on the welcome screen
  • Verify the skip-onboarding dialog shows the title and a single body line — the welcome screen's body 2 must not remain visible
  • Rotate the device while on the skip-onboarding screen and confirm body 2 is still hidden after rotation
  • Repeat with the welcome typing animation interrupted mid-way (tap skip while title is still typing); the same outcome should hold

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Note

Low Risk
Low risk UI/layout and copy update limited to onboarding welcome dialog; main risk is minor regressions in animation/visibility during dialog transitions or rotation.

Overview
Updates the brand-design onboarding welcome dialog to render the body copy as two separate lines (new bodyText1/bodyText2) with consistent spacing, and updates the fade-in/fade-out animations to animate both lines together.

Adjusts the skip-onboarding transition and non-animated state restoration to hide bodyText2 so the second welcome line can’t bleed into the skip dialog, and refreshes the welcome title/body strings to the new wording.

Reviewed by Cursor Bugbot for commit d55233b. Bugbot is set up for automated code reviews on this repo. Configure here.

@mikescamell mikescamell changed the title feat(onboarding): split welcome dialog body into two lines Onboarding Brand Design Update: Update welcome screen copy May 11, 2026
@mikescamell mikescamell force-pushed the feature/mike/onboarding-brand-design-updates/default-browser branch from 8967fc8 to f98ac15 Compare May 12, 2026 10:29
@mikescamell mikescamell force-pushed the onboarding-design-update-copy-changes branch from 92233df to 529d291 Compare May 12, 2026 10:29
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 529d291. Configure here.

android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="16dp"
android:layout_marginTop="20dp"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded 20dp margin doesn't match any keyline

Low Severity

The android:layout_marginTop="20dp" on both bodyText1 and bodyText2 is a hardcoded value that falls between @dimen/keyline_4 (16dp) and @dimen/keyline_5 (24dp) — no existing keyline corresponds to 20dp. Per the project's spacing convention, layout_margin* attributes in layout XML are expected to use @dimen/keyline_* references for consistent spacing.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by learned rule: Use @dimen/keyline_* references for margin and padding in layout XML

Reviewed by Cursor Bugbot for commit 529d291. Configure here.

@mikescamell mikescamell force-pushed the feature/mike/onboarding-brand-design-updates/default-browser branch from f98ac15 to d8b0eb8 Compare May 12, 2026 16:44
@mikescamell mikescamell force-pushed the onboarding-design-update-copy-changes branch from 529d291 to c74e5de Compare May 12, 2026 16:44
@mikescamell mikescamell force-pushed the feature/mike/onboarding-brand-design-updates/default-browser branch from d8b0eb8 to c014e0d Compare May 12, 2026 17:14
@mikescamell mikescamell force-pushed the onboarding-design-update-copy-changes branch from c74e5de to 6387c02 Compare May 12, 2026 17:14
Splits the welcome screen body copy into two DaxTextViews so the new
two-sentence wording can render with consistent spacing. Hides the
second line when transitioning to the skip-onboarding dialog so its
copy doesn't bleed through.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mikescamell mikescamell force-pushed the onboarding-design-update-copy-changes branch from 6387c02 to d55233b Compare May 12, 2026 17:38
@mikescamell mikescamell force-pushed the feature/mike/onboarding-brand-design-updates/default-browser branch from c014e0d to 4800237 Compare May 12, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant