Onboarding Brand Design Update: Update welcome screen copy#8515
Conversation
8967fc8 to
f98ac15
Compare
92233df to
529d291
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 529d291. Configure here.
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="16dp" | ||
| android:layout_marginTop="20dp" |
There was a problem hiding this comment.
Hardcoded 20dp margin doesn't match any keyline
Low Severity
The android:layout_marginTop="20dp" on both bodyText1 and bodyText2 is a hardcoded value that falls between @dimen/keyline_4 (16dp) and @dimen/keyline_5 (24dp) — no existing keyline corresponds to 20dp. Per the project's spacing convention, layout_margin* attributes in layout XML are expected to use @dimen/keyline_* references for consistent spacing.
Additional Locations (1)
Triggered by learned rule: Use @dimen/keyline_* references for margin and padding in layout XML
Reviewed by Cursor Bugbot for commit 529d291. Configure here.
f98ac15 to
d8b0eb8
Compare
529d291 to
c74e5de
Compare
d8b0eb8 to
c014e0d
Compare
c74e5de to
6387c02
Compare
Splits the welcome screen body copy into two DaxTextViews so the new two-sentence wording can render with consistent spacing. Hides the second line when transitioning to the skip-onboarding dialog so its copy doesn't bleed through. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6387c02 to
d55233b
Compare
c014e0d to
4800237
Compare



Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1213611375324061?focus=true
Description
Splits the welcome screen body copy into two text views so the new two-sentence wording renders with consistent spacing between lines. Hides the second body line when the welcome dialog transitions into the skip-onboarding screen so its copy doesn't bleed through.
Steps to test this PR
Welcome screen copy
Skip-onboarding transition
UI changes
Note
Low Risk
Low risk UI/layout and copy update limited to onboarding welcome dialog; main risk is minor regressions in animation/visibility during dialog transitions or rotation.
Overview
Updates the brand-design onboarding welcome dialog to render the body copy as two separate lines (new
bodyText1/bodyText2) with consistent spacing, and updates the fade-in/fade-out animations to animate both lines together.Adjusts the skip-onboarding transition and non-animated state restoration to hide
bodyText2so the second welcome line can’t bleed into the skip dialog, and refreshes the welcome title/body strings to the new wording.Reviewed by Cursor Bugbot for commit d55233b. Bugbot is set up for automated code reviews on this repo. Configure here.