Skip to content

Add the top section of the "what's new modal" (title and top image) as items in the RecyclerView so that the entire content is scrollable#7588

Merged
catalinradoiu merged 2 commits intodevelopfrom
feature/cradoiu/whats-new-top-section-scrollable
Feb 4, 2026
Merged

Add the top section of the "what's new modal" (title and top image) as items in the RecyclerView so that the entire content is scrollable#7588
catalinradoiu merged 2 commits intodevelopfrom
feature/cradoiu/whats-new-top-section-scrollable

Conversation

@catalinradoiu
Copy link
Copy Markdown
Contributor

@catalinradoiu catalinradoiu commented Jan 26, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1212974313804261?focus=true

Description

Refactored the remote messaging cards list UI to use a more flexible adapter pattern. The main changes include:

  • Created a new ModalListItem sealed class to represent different types of items in the list (Header and CardListItem)
  • Moved the header view from the main layout into a separate recyclerview item
  • Updated the adapter to handle the new item types
  • Simplified the view layout by removing redundant constraints and barriers
  • Added proper image loading with success/failure callbacks inside the new view holder
  • Improved the scrolling behavior by using the recyclerview for all content (therefore improving UX when having a longer list of items)

Steps to test this PR

Check the steps in this task and make sure that the scenarios below are working as expected:

  • Verify that the header displays correctly with both local and remote images
  • Confirm that card items render properly in the list
  • Check that scrolling works smoothly through the entire content
  • Ensure all action buttons function as expected

UI changes

Before After
what_new_non_scrollable.mp4 (uploaded via Graphite) whats_new_scrollable.mp4 (uploaded via Graphite)

Note

Makes the entire modal scrollable and simplifies rendering by treating the header as a list item.

  • Introduces ModalListItem (Header and CardListItem) and updates CardsListAdapter to render the header via a new ViewHolder with Glide image loading and success/failure callbacks
  • Refactors CardsListRemoteMessageViewModel to build modalListItems and expose primaryAction/primaryActionText; fires pixels on header image load and item visibility/clicks
  • Simplifies view_cards_list_remote_message.xml by removing embedded header; adds view_remote_message_header.xml for the header row
  • Updates CardsListRemoteMessageView to submit modalListItems and wire header image callbacks; replaces old header handling
  • Expands unit tests to cover new state shape, image file usage, actions, and pixel firing

Written by Cursor Bugbot for commit be4f3d4. This will update automatically on new commits. Configure here.

…s items in the RecyclerView so that the entire content is scrollable
Copy link
Copy Markdown
Contributor Author

catalinradoiu commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@catalinradoiu catalinradoiu merged commit 00e27bd into develop Feb 4, 2026
19 of 21 checks passed
@catalinradoiu catalinradoiu deleted the feature/cradoiu/whats-new-top-section-scrollable branch February 4, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants