Add UUID support to DuckDBAppender (fixes #313)#324
Conversation
Add UUID support to `DuckDBAppender` (fixes 313)
|
Hi, thanks for the PR, it looks good to me! To fix the formatting: python -m pip install --user clang_format==11.0.1
make format
make format-check |
|
@staticlibs thank you for the quick feedback. I refined the formatting. One quick question: I stumbled upon the |
The Appender is not intended to append the data concurrently, but it can be closed concurrently. For example, if the Appenders's connection is closed, the Appender is closed automatically. This connection close can well be triggered concurrently, for example from the shutdown cleanup code. After the Appender is closed - its native part is destroyed. And the destruction of the native part cannot be concurrent with it usage from other thread. Almost all |
|
Thank you for the thorough response. |
Previously, attempting to append a UUID would result in an
unsupported C API type: 27error which is documented in #313. This change enables theDuckDBAppenderto handlejava.util.UUIDobjects directly.