Skip to content

Fix incorrect character encoding in GetLastErrorAsString on Windows #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soutong wants to merge 2 commits into from
Closed

Fix incorrect character encoding in GetLastErrorAsString on Windows #323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e1bd73
Fix incorrect character encoding in GetLastErrorAsString on Windows
Jul 28, 2025
0856839
Fix incorrect character encoding in GetLastErrorAsString on Windows
Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/duckdb/src/common/local_file_system.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,12 +794,18 @@ std::string LocalFileSystem::GetLastErrorAsString() {
if (errorMessageID == 0)
return std::string(); // No error message has been recorded

LPSTR messageBuffer = nullptr;
LPWSTR messageBuffer = nullptr;
idx_t size =
FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
NULL, errorMessageID, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPSTR)&messageBuffer, 0, NULL);
FormatMessageW(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
NULL, errorMessageID, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPWSTR)&messageBuffer, 0, NULL);

std::string message(messageBuffer, size);
if (size == 0) {
return std::string();
}

// Convert wide string to UTF-8
std::wstring wideMessage(messageBuffer, size);
std::string message = WindowsUtil::UnicodeToUTF8(wideMessage.c_str());

// Free the buffer.
LocalFree(messageBuffer);
Expand Down