Fix builds by adding missing types.cpp to CMake#187
Merged
staticlibs merged 1 commit intoduckdb:mainfrom Apr 7, 2025
Merged
Conversation
In duckdb#168 `types.cpp` file was added to `CMakeLists.txt`, but, by mistake it was not added to `CMakeLists.txt.in` that is used to generate the `CMakeLists.txt` file on periodic engine sources import. This change adds `types.cpp` to both `CMakeLists.txt.in` and `CMakeLists.txt` to fix the build.
Collaborator
Author
|
Merging this without review to unbreak the builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #168
types.cppfile was added toCMakeLists.txt, but, by mistake it was not added toCMakeLists.txt.inthat is used to generate theCMakeLists.txtfile on periodic engine sources import.This change adds
types.cppto bothCMakeLists.txt.inandCMakeLists.txtto fix the build.