DatabaseMetadata schema introspection enhancements#167
Merged
Mytherin merged 1 commit intoduckdb:mainfrom Mar 21, 2025
Merged
Conversation
A few schema introspection functions in `DatabaseMetadata` take `catalog` and `schemaPattern` parameters with the following specific requirements: > catalog - a catalog name; must match the catalog name as it is stored in the database; "" retrieves those without a catalog; null means that the catalog name should not be used to narrow the search > schemaPattern - a schema name pattern; must match the schema name as it is stored in the database; "" retrieves those without a schema; null means that the schema name should not be used to narrow the search This change makes the handling for these parameters consistent between `getSchemas`, `getTables`, `getColumns`, `getPrimaryKeys`, `getIndexInfo` and `getFunctions` functions. Additionally it fixes the escaping for `functionNamePattern` parameter in `getFunctions`. Testing: test coverage added for enahanced `catalog` and `schemaPattern` handling. Fixes: duckdb#165
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few schema introspection functions in
DatabaseMetadatatakecatalogandschemaPatternparameters with the following specific requirements:This change makes the handling for these parameters consistent between
getSchemas,getTables,getColumns,getPrimaryKeys,getIndexInfoandgetFunctionsfunctions. Additionally it fixes the escaping forfunctionNamePatternparameter ingetFunctions.Testing: test coverage added for enhanced
catalogandschemaPatternhandling.Fixes: #165