Skip to content

Update upload-artifact action to v4#161

Merged
Mytherin merged 1 commit intoduckdb:mainfrom
staticlibs:upload_artifact_v4
Mar 14, 2025
Merged

Update upload-artifact action to v4#161
Mytherin merged 1 commit intoduckdb:mainfrom
staticlibs:upload_artifact_v4

Conversation

@staticlibs
Copy link
Collaborator

This action needs to be updated to allow workflow runs, details.

@staticlibs
Copy link
Collaborator Author

@Mytherin

M, jemalloc is failing on Windows for some reason. I will try it on Windows now. I wonder whether it is possible to merge this upload-artifact fix (so actions for other PRs can run) and I then fix the jemalloc in a separate PR?

@Mytherin Mytherin merged commit d2c82b2 into duckdb:main Mar 14, 2025
6 of 7 checks passed
@Mytherin
Copy link
Contributor

Sure, thanks!

FYI jemalloc shouldn't be used on Windows - elsewhere we enable it only on Linux. I think the fix here would be finding why this gets enabled on Windows and then disabling it.

@staticlibs staticlibs deleted the upload_artifact_v4 branch March 14, 2025 16:02
@staticlibs
Copy link
Collaborator Author

@Mytherin

Thanks for merging it! Just FYI, the PR that disables jemalloc on Windows (passes all CI actions) - #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants