Merged
Conversation
Author
|
I didn't touch the file that failed the format check, so I think it's fine |
Member
|
Can you perhaps fix the format while you're here |
Contributor
|
Thanks @lnkuiper ! |
added 2 commits
January 27, 2025 12:08
Author
|
@hannes, I've fixed the format check. The issue was not wrongly formatted code, but the clang-format version in CI was wrong. I've now made it install the same version as we use in the main duckdb repo again. |
Contributor
|
Thanks for getting this merged! |
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Mar 14, 2025
The jemalloc extention was recently added to JDBC builds in duckdb#133. The logic for its selection in `vendor.py` does not look fully correct to me, but both Linux and Mac are passing on CI, only Windows is breaking, so this change only tries to unbreak Windows builds, and the jemalloc selection logic can be improved in subsequent PRs.
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Mar 14, 2025
The jemalloc extention was recently added to JDBC builds in duckdb#133. The logic for its selection in `vendor.py` does not look fully correct to me, but both Linux and Mac are passing on CI, only Windows is breaking, so this change only tries to unbreak Windows builds, and the jemalloc selection logic can be improved in subsequent PRs.
staticlibs
added a commit
to staticlibs/duckdb-java
that referenced
this pull request
Mar 14, 2025
The jemalloc extention was recently added to JDBC builds in duckdb#133. The logic for its selection in `vendor.py` does not look fully correct to me, but both Linux and Mac are passing on CI, only Windows is breaking, so this change only tries to unbreak Windows builds, and the jemalloc selection logic can be improved in subsequent PRs.
This was referenced Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to help out #131
I don't think it's necessary to vendor in the changes, the CI will do that by itself. Just changing the vendor script should be enough. This should hopefully avoid conflicts.
Big thanks to @brianwyka for making the changes to the script! I simply copied them here.