build: prevent unused imports

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/CheckValidator.java

@@ -379,7 +379,7 @@ public void checkCategoryName(final Category category) {
   /**
    * Checks that given package name is a valid fully qualified name.
    *
-   * @see {@link CheckJavaValidatorUtil#isValidFullyQualifiedName(String)}
+   * @see CheckJavaValidatorUtil#isValidFullyQualifiedName(String)
    * @param catalog
    *          the catalog
    */

com.avaloq.tools.ddk.check.lib/src/com/avaloq/tools/ddk/check/lib/IResourceCache.java

@@ -35,7 +35,7 @@ public interface IResourceCache {
    * <em>Note:</em> throws
    * </p>
    * <ul>
-   * <li>{@link IllegalArgumentException} if {@code context} or {@code key} are {@©ode null}.</li>
+   * <li>{@link IllegalArgumentException} if {@code context} or {@code key} are {@code null}.</li>
    * <li>{@link IllegalStateException} if the resource of {@code context} is not an Xtext resource.</li>
    * </ul>
    *
@@ -57,7 +57,7 @@ public interface IResourceCache {
    * <em>Note:</em> throws
    * </p>
    * <ul>
-   * <li>{@link IllegalArgumentException} if {@code context} or {@code key} are {@©ode null}.</li>
+   * <li>{@link IllegalArgumentException} if {@code context} or {@code key} are {@code null}.</li>
    * <li>{@link IllegalStateException} if the resource of {@code context} is not an Xtext resource.</li>
    * <li>{@link ClassCastException} if the value cannot be converted to type T.</li>
    * </ul>
@@ -78,7 +78,7 @@ public interface IResourceCache {
    * <em>Note:</em> throws
    * </p>
    * <ul>
-   * <li>{@link IllegalArgumentException} if {@code context} or {@code key} are {@©ode null}.</li>
+   * <li>{@link IllegalArgumentException} if {@code context} or {@code key} are {@code null}.</li>
    * <li>{@link IllegalStateException} if the resource of {@code context} is not an Xtext resource.</li>
    * </ul>
    *
@@ -96,7 +96,7 @@ public interface IResourceCache {
    * <em>Note:</em> throws
    * </p>
    * <ul>
-   * <li>{@link IllegalArgumentException} if {@code context} is {@©ode null}.</li>
+   * <li>{@link IllegalArgumentException} if {@code context} is {@code null}.</li>
    * <li>{@link IllegalStateException} if the resource of {@code context} is not an Xtext resource.</li>
    * </ul>
    *

com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/validation/CheckValidatorTest.java

@@ -43,7 +43,7 @@ protected String getHostLanguage() {
   /**
    * Tests that the dummy validator is found via the check validator extension point.
    *
-   * @see {@link com.avaloq.tools.ddk.check.extensionpoint.test.validation.DummyValidator}
+   * @see com.avaloq.tools.ddk.check.extensionpoint.test.validation.DummyValidator
    */
   @Test
   void testAtLeastOneValidatorFound() {

com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/ICheckCatalogImpl.java

@@ -18,7 +18,7 @@
  * Resources containing check catalogs are identified by the optional {@code catalog} extension attribute.
  * Descriptors of this kind are created for check validator extensions.
  * 
- * @see {@link com.avaloq.tools.ddk.check.runtime.internal.CheckCatalogDescriptor}
+ * @see com.avaloq.tools.ddk.check.runtime.internal.CheckCatalogDescriptor
  */
 public interface ICheckCatalogImpl extends Resource {
 

com.avaloq.tools.ddk.check.runtime.ui/src/com/avaloq/tools/ddk/check/runtime/ui/editor/PlatformPluginAwareEditorOpener.java

@@ -68,7 +68,7 @@ public class PlatformPluginAwareEditorOpener extends LanguageSpecificURIEditorOp
   /**
    * If a platform plugin URI is given, a read-only Xtext editor is opened and returned. {@inheritDoc}
    *
-   * @see {@link org.eclipse.emf.common.util.URI#isPlatformPlugin()}
+   * @see org.eclipse.emf.common.util.URI#isPlatformPlugin()
    */
   @Override
   public IEditorPart open(final URI uri, final EReference crossReference, final int indexInList, final boolean select) {

com.avaloq.tools.ddk.checkcfg.core/src/com/avaloq/tools/ddk/checkcfg/validation/CheckCfgValidator.java

@@ -117,7 +117,7 @@ private boolean isParameterConfigured(final ConfiguredCheck configuredCheck) {
   /**
    * Checks that final catalogs are not configured for severity.
    *
-   * @see {@link com.avaloq.tools.ddk.check.check.CheckCatalog#isFinal()}
+   * @see com.avaloq.tools.ddk.check.check.CheckCatalog#isFinal()
    * @param catalog
    *          the configured catalog
    */

com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/jupiter/BugTestAwareRule.java

@@ -21,7 +21,7 @@
 /**
  * This {@link InvocationInterceptor} implementation changes the behavior for unresolved bug tests.
  * <p>
- * The behavior for at test that is annotated with {@link BugTest(unresolved=true)} is the following:
+ * The behavior for at test that is annotated with {@link BugTest} (with {@code unresolved=true}) is the following:
  * <ul>
  * <li>Test evaluation <code>OK</code> results in <code>FAIL</code> ({@link AssertionError})</li>
  * <li>Test evaluation <code>FAIL</code> results in <code>OK</code></li>

com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/jupiter/IssueAwareRule.java

@@ -22,7 +22,7 @@
 /**
  * This {@link InvocationInterceptor} implementation changes the behavior for not fixed issues.
  * <p>
- * The behavior for at test that is annotated with {@link Issue(fixed = false)} is the following:
+ * The behavior for at test that is annotated with {@link Issue} (with {@code fixed = false}) is the following:
  * <ul>
  * <li>Test evaluation <code>OK</code> results in <code>FAIL</code> ({@link AssertionError})</li>
  * <li>Test evaluation <code>FAIL</code> results in <code>OK</code></li>

com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java

@@ -94,7 +94,7 @@ public static void mockExecutableExtension(final IConfigurationElement mockedEle
 
   /**
    * Mocks an {@link IConfigurationElement} for an extension point with the given id. The extension point is only mocked via
-   * {@link IExtensionRegistry#getConfigurationElementsFor(String) and will not be visible otherwise.
+   * {@link IExtensionRegistry#getConfigurationElementsFor(String)} and will not be visible otherwise.
    *
    * @param extensionPointId
    *          the fully-qualified id for the extension point, must not be {@code null}

com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/FixedDefaultWorkbench.java

@@ -31,7 +31,8 @@
  */
 class FixedDefaultWorkbench {
 
-  /** @see org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.getLimboShell() */
+  /** @see org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine#getLimboShell() */
+  @SuppressWarnings("restriction")
   private static final String LIMBO_SHELL = "PartRenderingEngine's limbo"; //$NON-NLS-1$
   private static final String QUIK_ACCESS_SHELL = "Quick Access"; //$NON-NLS-1$
 

com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/GenModelUtil2.java

@@ -64,7 +64,7 @@ public static String qualifiedPackageInterfaceName(final EPackage ePackage) {
   /**
    * Formats a name by parsing it into words separated by underscores and/or mixed-casing and then
    * recombining them using the specified separator.
-   * {@see CodeGenUtil#format(String, char, String, boolean, boolean)
+   * {@link CodeGenUtil#format(String, char, String, boolean, boolean)}
    *
    * @param name
    *          the name to format

com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/IllegalJUnitAnnotation.java

@@ -11,7 +11,7 @@
 package com.avaloq.tools.ddk.xtext.test;
 
 /**
- * Raised when a test wants to annotate a method with either a {@link @BeforeClass} or a {@link @AfterClass} annotation.
+ * Raised when a test wants to annotate a method with either a {@code @BeforeClass} or a {@code @AfterClass} annotation.
  */
 public class IllegalJUnitAnnotation extends RuntimeException {
   private static final long serialVersionUID = 1L;

com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java

@@ -682,7 +682,7 @@ protected String link(final Supplier<EObject> getTargetObject) {
   }
 
   /**
-   * Performs linking test. Checks expectations which were set in a source using {@link #link(int)} or {@link #link(Function, int).
+   * Performs linking test. Checks expectations which were set in a source using {@link #link(int)} or {@link #link(Function, int)}.
    *
    * @see #link(int)
    * @see #link(Supplier)
@@ -695,7 +695,7 @@ protected void testLinking(final Pair<String, String> sourceFileNameAndContent)
   }
 
   /**
-   * Performs linking test. Checks expectations which were set in a source using {@link #link(int)} or {@link #link(Function, int).
+   * Performs linking test. Checks expectations which were set in a source using {@link #link(int)} or {@link #link(Function, int)}.
    *
    * @see #link(int)
    * @see #link(Supplier)

com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java

@@ -642,7 +642,7 @@ protected String getAdditionalErrorMessageInformation() {
   }
 
   /**
-   * Returns an unmodifiable view of the tags generated by {@link getTag()}.
+   * Returns an unmodifiable view of the tags generated by {@link #getTag()}.
    *
    * @return the unmodifiable view of the {@link #usedTags} set
    */

com.avaloq.tools.ddk.xtext.ui.test/src/com/avaloq/tools/ddk/xtext/ui/templates/TemplateVariableResolverTestHelper.java

@@ -35,18 +35,17 @@ public class TemplateVariableResolverTestHelper {
    * Create a {@link TemplateVariable}.
    *
    * @param resolver
-   *          {@link TemplateVariableResolver@} of the type which will resolve the {@link TemplateVariable} created, may not be {@code null}
+   *          {@link TemplateVariableResolver} of the type which will resolve the {@link TemplateVariable} created, may not be {@code null}
    * @param name
    *          the name of the variable, may not be {@code null}
    * @param values
    *          the values available at this variable, non-empty, may not be {@code null}
    * @return a {@link TemplateVariable}
-   * @throws {@link
-   *           NullPointerException} if resolver.getType(), name or values is null
-   * @throws {@link
-   *           IllegalArgumentException} if resolver.getType() or name contains whitespace or values is empty
-   * @throws {@link
-   *           TemplateException}
+   * @throws NullPointerException
+   *           if resolver.getType(), name or values is null
+   * @throws IllegalArgumentException
+   *           if resolver.getType() or name contains whitespace or values is empty
+   * @throws TemplateException
    *           if translation failed
    */
   public TemplateVariable createTemplateVariable(final TemplateVariableResolver resolver, final String name, final Object... values) throws NullPointerException, IllegalArgumentException, TemplateException {

com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/quickfix/WorkbenchMarkerResolutionGenerator.java

@@ -116,8 +116,8 @@ public XtextEditor getEditor(final IResource resource) {
    * This method may not be called in this implementation.
    * Use getAdaptedResolutions(final List<IssueResolution> resolutions, final IMarker marker).
    *
-   * @throws {@code
-   *           NotImplementedException} if called
+   * @throws NotImplementedException
+   *           if called
    */
   @Override
   protected IMarkerResolution[] getAdaptedResolutions(final List<IssueResolution> resolutions) {

com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/IExtendedLocator.java

@@ -28,7 +28,8 @@ enum AggregationPolicy {
    * Get the locator's aggregation policy. OVERRIDE locators (e.g. NoLinewrapLocatorFacade)
    * are not combined, whereas COMBINED_MAXIMUM locators are combined/aggregated, and ADDITIVE locators are added to previous locators.
    *
-   * @see {@link com.avaloq.tools.ddk.xtext.formatting.SpaceEntry SpaceEntry} and {@link com.avaloq.tools.ddk.xtext.formatting.WrapEntry WrapEntry}
+   * @see com.avaloq.tools.ddk.xtext.formatting.SpaceEntry
+   * @see com.avaloq.tools.ddk.xtext.formatting.WrapEntry
    * @return policy of locator
    */
   AggregationPolicy getPolicy();

com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/RightPaddingLocator.java

@@ -34,7 +34,7 @@ public class RightPaddingLocator extends ElementLocator implements ISpaceLocator
    *          the formatting configuration
    * @param length
    *          the minimum amount of space allocated for an entry
-   * @see {@link #getPadding(ExtendedLineEntry)}
+   * @see #getPadding(ExtendedLineEntry)
    */
   public RightPaddingLocator(final FormattingConfig formattingConfig, final int length) { // NOPMD CallSuperInConstructor - false positive by PMD
     formattingConfig.super();

com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/ILazyLinkingResource2.java

@@ -39,7 +39,7 @@ public interface ILazyLinkingResource2 extends Resource.Internal {
    * Creates diagnostics for given triple.
    *
    * @param triple
-   *          triple <EObject, EReference, INode>, must not be {@code null}
+   *          triple {@code <EObject, EReference, INode>}, must not be {@code null}
    */
   void createAndAddDiagnostic(Triple<EObject, EReference, INode> triple);
 

ddk-configuration/checkstyle/avaloq.xml

@@ -21,6 +21,7 @@
     <module name="UnnecessarySemicolonAfterTypeMemberDeclaration"/>
     <module name="UnnecessarySemicolonInEnumeration"/>
     <module name="UnnecessarySemicolonInTryWithResources"/>
+    <module name="UnusedImports"/>
     <module name="VariableDeclarationUsageDistance"/>
     <module name="CatchParameterName"/>
     <module name="LambdaParameterName"/>
@@ -38,6 +39,7 @@
       <property name="allowInSwitchCase" value="true"/>
     </module>
     <module name="AvoidStarImport"/>
+    <module name="UnusedImports"/>
     <module name="BooleanExpressionComplexity"/>
     <module name="CovariantEquals"/>
     <!--module name="ClassFanOutComplexity"/-->