refactor: migrate Xtend to Java - com.avaloq.tools.ddk.check.test.runtime.tests#1356
Merged
Merged
Conversation
…time.tests Migrate the three remaining .xtend test files to idiomatic Java 21, remove the module's Xtend infrastructure (MANIFEST.MF Require-Bundle, build.properties source roots, .classpath xtend-gen entry, .project xtextBuilder/xtextNature) and delete the now-empty xtend-gen/ tree. The three tests preserve their original behaviour: - CheckExecutionEnvironmentProjectTest: ParseHelper + ValidationTestHelper driving five validation assertions. - CheckConfigurationIsAppliedTest: copies sources into the workspace, waits for the Xtext builder and asserts the configured severity. - IssueLabelTest: end-to-end ICheckRuleLabelProvider label lookups using Guice with an empty AbstractModule binding the just-in-time defaults. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rubenporras
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the last three
.xtendtest files incom.avaloq.tools.ddk.check.test.runtime.teststo Java 21; the module is now fully Java.Notable swaps:
Lists.newArrayList→List.of;CollectionLiterals.newHashMap+Pair.of→Map.of;Exceptions.sneakyThrow→ declaredthrows Exception.AbstractModuleanonymous class kept for parity with the original.Infrastructure cleanup: drop
xtend.lib/xbase.libfromRequire-Bundle,xtend-gen/frombuild.propertiesand.classpath,xtextBuilder/xtextNaturefrom.project, and thextend-gen/tree itself.Test plan
mvn clean compile checkstyle:check pmd:check spotbugs:check→ BUILD SUCCESS.eclipse-plugin, noteclipse-test-plugin— pre-existing).🤖 Generated with Claude Code