fix: restore missing listAttribute opener in ExportTestSuite.launch#1343
Merged
joaodinissf merged 1 commit intoMay 18, 2026
Merged
Conversation
The opening <listAttribute key="org.eclipse.debug.core.MAPPED_RESOURCE_PATHS"> tag was dropped in 38918bc ("feat: use junit5 platform in our tests"), which replaced it with the new ATTR_FORCE_SYSTEM_CONSOLE_ENCODING attribute instead of inserting alongside. The following <listEntry> and </listAttribute> have been orphaned ever since, leaving the file malformed XML. Eclipse PDE's launch-config parser was lenient enough to keep the launch usable, but Eclipse's XML language server flags it as a parse error. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rubenporras
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opening
<listAttribute key="org.eclipse.debug.core.MAPPED_RESOURCE_PATHS">tag was dropped in 38918bc (feat: use junit5 platform in our tests), which replaced it with the newATTR_FORCE_SYSTEM_CONSOLE_ENCODINGattribute instead of inserting alongside. The following<listEntry>and</listAttribute>have been orphaned ever since, leaving the file malformed XML.Eclipse PDE's launch-config parser was lenient enough to keep the launch usable, but Eclipse's XML language server now flags it as a parse error:
xmllint --nooutconfirms the file is well-formed after the fix; all other.launchfiles in the repo were already valid.🤖 Generated with Claude Code