chore: switch Xtext target to 2.43.0 stable#1332
Closed
joaodinissf wants to merge 3 commits into
Closed
Conversation
No DDK source still depends on JUnit 4. This commit drops org.junit and junit-vintage-engine from the ddk.target IUs and from Require-Bundle across 7 bundle manifests, removes stale Export-Package entries for already-deleted packages, and switches swtbot.eclipse.test.junit.feature.group to swtbot.junit5.feature.group. Two non-mechanical bits: xtext.test's manifest gains an explicit Require-Bundle on junit-platform-suite-engine — the runtime executor for @Suite/@SelectClasses, previously resolved transitively by luck, and the absence of which is what made the silent-zero possible. And com.avaloq.tools.ddk.test.core.MultipleTestProblems (the JUnit 4 implementation using MultipleFailureException) is deleted; its sole user CompoundStep switches to the existing jupiter/MultipleTestProblems which uses org.opentest4j.MultipleFailuresError. Verified locally: 357 tests, 0 failures, 0 errors, BUILD SUCCESS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…Xtext End-to-end JUnit 6 + Eclipse 4.39 upgrade. Verified locally: 357 tests, 0 failures, 0 errors. The OSGi runtime contains only JUnit 6.0.3 bundles (no JUnit 5.14.x, no jdt.junit5.runtime). Two layers of dual-version JUnit pollution had to be peeled back: 1. Eclipse PDE umbrella feature transitively pulls jdt.junit5.runtime (strict-pinned to JUnit 5.14.x). Workaround: replace org.eclipse.pde.feature.group in the target with a curated bundle list of the six PDE bundles DDK uses (pde.core, pde.ui, pde.ua.core, pde.junit.runtime, jdt.junit.runtime, jdt.annotation). Verified load-bearing: dropping the curated list and going back to pde.feature.group makes target resolution unsatisfiable. 2. Xtext 2.42.0's org.eclipse.xtext.testing hard-pins org.junit.jupiter.api [5.1.0,6.0.0). Fix: eclipse-xtext/xtext#3660 "Junit 6 support" landed in Xtext 2.43.0. This branch points at the 2.43.0.M2 milestone; a one-line follow-up PR will flip the URL to releases/2.43.0/ once stable ships on 2026-05-25. Branch convention exception: this PR uses an Xtext milestone URL rather than a stable release. The standing project rule is stable-only. The exception is narrow: blocker fully understood, upstream fix confirmed in M2, stable date on the horizon, and a follow-up PR is planned to swap to stable. Other target file changes: - sequenceNumber 28 -> 29 - Eclipse SDK location updates/4.34/ -> releases/2026-03/ - Source-feature IUs (platform.source.feature.group, jdt.source.*, pde.source.*) dropped — renamed in modern simrels and not needed for headless Tycho test runs. - swtbot.junit5.feature.group dropped — its feature.xml requires the JUnit 4 'org.junit' bundle which is no longer in the target, and DDK doesn't use SWTBotJunit5Extension (verified via static analysis). - orbit-aggregation 4.37.0 -> 4.39.0 with JUnit 6.0.3 IUs and dep versions back to 4.39-era (mockito 5.21.0, byte-buddy 1.18.5, objenesis 3.5.0, commons-lang3 3.20.0, commons-text 1.15.0, log4j 2.25.3). xtext.test/pom.xml: - <providerHint>junit5</providerHint> -> <providerHint>junit6</providerHint> - extraRequirements: replaced the org.eclipse.pde feature requirement with an explicit org.eclipse.pde.junit.runtime plugin requirement Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #1327 — the stable-URL swap is now folded into the parent PR. Closing. — left by Claude at João's request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the Xtext repository URL from
updates/milestones/2.43.0.M2/→updates/releases/2.43.0/once Xtext 2.43.0 stable ships on 2026-05-25. Stays draft until then because the stable URL doesn't resolve yet.🤖 Generated with Claude Code