chore: drop JUnit 4 from target and bundle manifests#1326
Merged
joaodinissf merged 1 commit intoMay 22, 2026
Conversation
This was referenced May 1, 2026
joaodinissf
force-pushed
the
chore/drop-junit4-target-step-3
branch
2 times, most recently
from
a902c2f to
950b810
Compare
rubenporras
reviewed
May 7, 2026
| junit-jupiter-api | ||
| Import-Package: org.apache.logging.log4j | ||
| Export-Package: com.avaloq.tools.ddk.xtext.test, | ||
| com.avaloq.tools.ddk.xtext.test.contentassist, |
Member
There was a problem hiding this comment.
we should not remove this exports.
Collaborator
Author
There was a problem hiding this comment.
The packages those entries point to were deleted in d920b3b.
They had become dead code in this repo and all downstream repos following the JUnit 5 migration — platform setup in 38918bc, per-module migrations in be881df, bd5dd6d, c0dd0ad, 1828d2b and cadb87b, final assertion cleanup in 425c26f.
There was one leftover trivial fix that was overlooked, which I will prepare.
rubenporras
requested changes
May 7, 2026
Member
rubenporras
left a comment
rubenporras
left a comment
There was a problem hiding this comment.
see comment about the export removal
No DDK source still depends on JUnit 4. This commit drops org.junit and junit-vintage-engine from the ddk.target IUs and from Require-Bundle across 7 bundle manifests, removes stale Export-Package entries for already-deleted packages, and switches swtbot.eclipse.test.junit.feature.group to swtbot.junit5.feature.group. Two non-mechanical bits: xtext.test's manifest gains an explicit Require-Bundle on junit-platform-suite-engine — the runtime executor for @Suite/@SelectClasses, previously resolved transitively by luck, and the absence of which is what made the silent-zero possible. And com.avaloq.tools.ddk.test.core.MultipleTestProblems (the JUnit 4 implementation using MultipleFailureException) is deleted; its sole user CompoundStep switches to the existing jupiter/MultipleTestProblems which uses org.opentest4j.MultipleFailuresError. Verified locally: 357 tests, 0 failures, 0 errors, BUILD SUCCESS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/drop-junit4-target-step-3
branch
from
950b810 to
848aad4
Compare
rubenporras
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No DDK source still depends on JUnit 4. This PR drops
org.junitandjunit-vintage-enginefrom theddk.targetIUs and fromRequire-Bundleacross 7 bundle manifests, removes staleExport-Packageentries for already-deleted packages, and switchesswtbot.eclipse.test.junit.feature.grouptoswtbot.junit5.feature.group.mvn clean verifylocally: 357 tests, 0 failures, 0 errors.Two non-mechanical bits:
xtext.test's manifest gains an explicitRequire-Bundleonjunit-platform-suite-engine— the runtime executor for@Suite/@SelectClasses, previously resolved transitively by luck, and the absence of which is what made #1292's silent-zero possible. Andcom.avaloq.tools.ddk.test.core.MultipleTestProblems(the JUnit 4 implementation usingMultipleFailureException) is deleted; its sole userCompoundStepswitches to the existingjupiter/MultipleTestProblemswhich usesorg.opentest4j.MultipleFailuresError.🤖 Generated with Claude Code