ci: pin actions to SHAs and remove setup-maven#1310
Merged
Conversation
Mutable version tags (v6, v5, etc.) can be force-pushed by action maintainers, making them a supply-chain risk. Pin all actions in verify.yml to immutable commit SHAs with version comments. - actions/checkout v6.0.2 (de0fac2e) - actions/setup-java v5.2.0 (be666c2f) - actions/cache v5.0.5 (27d5ce7f) - actions/upload-artifact v7.0.1 (043fb46d) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ubuntu 24.04 runners ship Maven 3.9.14, which satisfies the enforcer rule [3.9.0,4) in ddk-parent. No need for stCarolas/setup-maven. Add a version logging step so the runner-provided Maven version is visible in CI output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
de680fb to
a5a00e8
Compare
rubenporras
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify.ymlto immutable commit SHAs (mutable version tags are a supply-chain risk)stCarolas/setup-maven— Ubuntu 24.04 runners ship Maven 3.9.14, covered by the enforcer rule[3.9.0,4)Actions pinned
actions/checkoutde0fac2eactions/setup-javabe666c2factions/cache27d5ce7factions/upload-artifact043fb46dAll SHAs verified against latest subversion tags.
Test plan
🤖 Generated with Claude Code