Skip to content

chore: enable PMD GuardLogStatement rule #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaodinissf merged 1 commit into from
May 19, 2026
Merged

chore: enable PMD GuardLogStatement rule #1284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ddk-configuration/pmd/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
<exclude name="UnusedPrivateMethod"/><!-- false positives-->
<exclude name="DefaultLabelNotLastInSwitch"/>
<exclude name="ForLoopCanBeForeach"/>
<exclude name="GuardLogStatement"/><!--TODO-->
<exclude name="ImplicitFunctionalInterface"/>
<exclude name="UnitTestAssertionsShouldIncludeMessage"/>
<exclude name="UnitTestContainsTooManyAsserts"/><!--New after PMD 5.3 upgrade, limitation to 1 assert not sensible, would need customization, disabled for the time being-->
Expand All @@ -88,6 +87,12 @@
<exclude name="UnusedLocalVariable"/><!--Checkstyle-->
<exclude name="JUnit5TestShouldBePackagePrivate"/>
</rule>
<rule ref="category/java/bestpractices.xml/GuardLogStatement">
<properties>
<property name="logLevels" value="trace,debug" />
<property name="guardsMethods" value="isTraceEnabled,isDebugEnabled" />
</properties>
</rule>
<rule ref="category/java/bestpractices.xml/UnusedFormalParameter">
<properties>
<property name="checkAll" value="true" />
Expand Down