feat: Migrate cat.ddk.check.runtime.core.test to Junit5#1208
Conversation
removed junit4 dependencies removed dependency to DiscerningSuite
markdomeng
force-pushed
the
runtime_core_j5
branch
from
39c78b5 to
4a8e617
Compare
| junit-jupiter-api, | ||
| junit-jupiter-engine, | ||
| junit-vintage-engine | ||
| junit-vintage-engine, |
There was a problem hiding this comment.
I have overlooked this in the other PRs. Should we not be able to remove junit-vintage-engine now?
There was a problem hiding this comment.
not completely I think.. if our downstream (asmd) project inherits or uses the abstract classes it might still need the vintage engine. just to be safe let's remove it when both asmd and ddk are completely running in native junit5 ?
There was a problem hiding this comment.
AFAIK, since we are not reexporthing them, what we have here is not relevantt for other plugins, so we should be able to remove them already.
There was a problem hiding this comment.
I see. then I will remove the vintage engine on packages that are not exported. thanks!
There was a problem hiding this comment.
I have added the cleanup in this pr #1209 1209
3 participants
removed junit4 dependencies
removed dependency to DiscerningSuite