Skip to content

chore: apply Eclipse PDE's "Organize Manifests" action to all manifests#1195

Closed
joaodinissf wants to merge 2 commits into
dsldevkit:masterfrom
joaodinissf:organize
Closed

chore: apply Eclipse PDE's "Organize Manifests" action to all manifests#1195
joaodinissf wants to merge 2 commits into
dsldevkit:masterfrom
joaodinissf:organize

Conversation

@joaodinissf
Copy link
Copy Markdown
Collaborator

No description provided.

@joaodinissf joaodinissf changed the title Organize chore: apply Eclipse PDE's "Organize Manifests" action to all manifests Oct 18, 2025
@joaodinissf
Copy link
Copy Markdown
Collaborator Author

joaodinissf commented Oct 18, 2025

I'll wait for Mark's JUnit5 PR to go in to rebase before merging this.

@joaodinissf joaodinissf force-pushed the organize branch 2 times, most recently from 65c09de to 0bfcd39 Compare October 18, 2025 12:18
Bundle-Version: 16.2.0.qualifier
Bundle-Vendor: Avaloq Group AG
Bundle-RequiredExecutionEnvironment: JavaSE-21
Bundle-ActivationPolicy: lazy
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to keep the lazy activation, don't we?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.pde.doc.user%2Fguide%2Ftools%2Fpde_actions%2Forganize_manifests.htm

The Remove unnecessary lazy activation headers option will remove lazy activation headers if a Bundle-Activator is not defined. If a bundle has nothing to contribute when it is started, a lazy activation header is not necessary.

Copy link
Copy Markdown
Member

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the lazy activations?

@joaodinissf joaodinissf closed this Dec 3, 2025
@joaodinissf
Copy link
Copy Markdown
Collaborator Author

joaodinissf commented Dec 3, 2025

Closing for now, as we have seen in the past that some of these automatic removals can be false positives that are not immediately obvious to notice/revert.

@joaodinissf joaodinissf deleted the organize branch December 3, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants