feat: Migrate cat.ddk.xtext.ui.test to Junit5 by markdomeng · Pull Request #1191 · dsldevkit/dsl-devkit

markdomeng · 2025-10-17T08:37:02Z

removed junit4 dependencies
removed dependency to DiscerningSuite. Once we migrate the DiscerningSuite to Junit5 we can use it again here

removed junit4 dependencies removed dependency to DiscerningSuite. Once we migrate the DiscerningSuite to Junit5 we can use it again here

rubenporras · 2025-10-18T05:00:20Z

+import org.junit.platform.suite.api.SelectClasses;
+import org.junit.platform.suite.api.Suite;

 import com.avaloq.tools.ddk.test.core.junit.runners.DiscerningSuite;


this import needs to be removed.

rubenporras

You need to remove the unused import.

Then, PMD gives several warnings on other classes, could you address this?

Finally, I think it would be good if you could approve and rebase on #1192.

markdomeng · 2025-10-21T03:54:34Z

You need to remove the unused import.

Then, PMD gives several warnings on other classes, could you address this?

Finally, I think it would be good if you could approve and rebase on #1192.

they look fals positive:
[INFO] �[1m--- �[0;32mpmd:3.28.0:check�[m �[1m(default-cli)�[m @ �[36mcom.avaloq.tools.ddk.xtext.ui.test�[0;1m ---�[m
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:59 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:99 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:30 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:41 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.ResourceNameTemplateVariableResolverTest:37 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.SimpleEnumTemplateVariableResolverTest:36 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:59 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorRunTest:99 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:30 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.quickfix.WorkbenchResolutionAdaptorTest:41 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor should not explicitly throw java.lang.Exception.
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.ResourceNameTemplateVariableResolverTest:37 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[WARNING] PMD Failure: com.avaloq.tools.ddk.xtext.ui.templates.SimpleEnumTemplateVariableResolverTest:36 Rule:JUnit5TestShouldBePackagePrivate Priority:3 JUnit 5 tests should be package-private..
[INFO]

example:
The first warning is issued on the CLASS declaration, this is not right. java class should be public.
the second one is issued on setup() but in some classes it is not issued..

I think pMD is just not working correctly yest with Junit5 ?

removed junit4 dependencies removed dependency to DiscerningSuite. Once we migrate the DiscerningSuite to Junit5 we can use it again here

joaodinissf · 2025-10-22T18:40:31Z

LGTM after fixing the small syntax issue I commented above. @rubenporras ?

…ext/ui/test/XtextUiTestSuite.java Fix formatting Co-authored-by: João Dinis Ferreira <hello@joaof.eu>

rubenporras · 2025-10-23T04:38:53Z

LGTM as well

markdomeng requested review from joaodinissf and rubenporras October 17, 2025 08:38

rubenporras previously approved these changes Oct 17, 2025

View reviewed changes

feat: Migrate cat.ddk.xtext.ui.test to Junit5

635ecdc

removed junit4 dependencies removed dependency to DiscerningSuite. Once we migrate the DiscerningSuite to Junit5 we can use it again here

markdomeng dismissed rubenporras’s stale review via 635ecdc October 17, 2025 14:23

markdomeng force-pushed the xtext_ui_test_j5 branch from 91c414a to 635ecdc Compare October 17, 2025 14:23

rubenporras reviewed Oct 18, 2025

View reviewed changes

rubenporras requested changes Oct 18, 2025

View reviewed changes

joaodinissf requested changes Oct 21, 2025

View reviewed changes

joaodinissf reviewed Oct 21, 2025

View reviewed changes

Comment thread ...xt.ui.test/src/com/avaloq/tools/ddk/xtext/ui/quickfix/WorkbenchResolutionAdaptorRunTest.java Outdated

Comment thread ...xtext.ui.test/src/com/avaloq/tools/ddk/xtext/ui/quickfix/WorkbenchResolutionAdaptorTest.java Outdated

feat: Migrate cat.ddk.xtext.ui.test to Junit5

915d4c1

removed junit4 dependencies removed dependency to DiscerningSuite. Once we migrate the DiscerningSuite to Junit5 we can use it again here

markdomeng force-pushed the xtext_ui_test_j5 branch from 91d6488 to 915d4c1 Compare October 21, 2025 14:09

joaodinissf reviewed Oct 22, 2025

View reviewed changes

Comment thread com.avaloq.tools.ddk.xtext.ui.test/src/com/avaloq/tools/ddk/xtext/ui/test/XtextUiTestSuite.java Outdated

Update com.avaloq.tools.ddk.xtext.ui.test/src/com/avaloq/tools/ddk/xt…

1682f7a

…ext/ui/test/XtextUiTestSuite.java Fix formatting Co-authored-by: João Dinis Ferreira <hello@joaof.eu>

rubenporras approved these changes Oct 23, 2025

View reviewed changes

joaodinissf approved these changes Oct 23, 2025

View reviewed changes

markdomeng merged commit 991d16a into dsldevkit:master Oct 23, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Migrate cat.ddk.xtext.ui.test to Junit5#1191

feat: Migrate cat.ddk.xtext.ui.test to Junit5#1191
markdomeng merged 3 commits into
dsldevkit:masterfrom
markdomeng:xtext_ui_test_j5

markdomeng commented Oct 17, 2025

Uh oh!

rubenporras Oct 18, 2025

Uh oh!

rubenporras left a comment •

edited

Loading

Uh oh!

markdomeng commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaodinissf commented Oct 22, 2025

Uh oh!

rubenporras commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

markdomeng commented Oct 17, 2025

Uh oh!

rubenporras Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

rubenporras left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markdomeng commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaodinissf commented Oct 22, 2025

Uh oh!

rubenporras commented Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rubenporras left a comment •

edited

Loading