suppress existing nls workspace warnings

com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/AbstractCheckTestCase.java

@@ -60,7 +60,7 @@
 /**
  * An abstract test class for tests on Check models. Allows creating a project and adding files.
  */
-@SuppressWarnings({"PMD.SignatureDeclareThrowsException", "restriction"})
+@SuppressWarnings({"PMD.SignatureDeclareThrowsException", "restriction", "nls"})
 public abstract class AbstractCheckTestCase extends TestCase {
   private static final int TWO_KILO_BYTES = 2048;
   protected static final Logger LOGGER = LogManager.getLogger(AbstractCheckTestCase.class);

com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugAig1314.java

@@ -41,6 +41,7 @@
  */
 @RunWith(XtextRunner.class)
 @InjectWith(CheckInjectorProvider.class)
+@SuppressWarnings("nls")
 public class BugAig1314 {
 
   /** Constructor of super class is protected... */

com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugDsl27.java

@@ -26,6 +26,7 @@
  */
 @InjectWith(CheckInjectorProvider.class)
 @RunWith(XtextRunner.class)
+@SuppressWarnings("nls")
 public class BugDsl27 extends AbstractCheckGenerationTestCase {
 
   /**

com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtilTest.java

@@ -28,6 +28,7 @@
 
 @InjectWith(CheckUiInjectorProvider.class)
 @RunWith(XtextRunner.class)
+@SuppressWarnings("nls")
 public class CheckJavaValidatorUtilTest extends TestCase {
 
   // assertion messages.

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/documentation/JavaDocCommentDocumentationProvider.java

@@ -25,6 +25,7 @@
 /**
  * @author Christoph Kulla - Initial contribution and API
  */
+@SuppressWarnings("nls")
 public class JavaDocCommentDocumentationProvider implements IEObjectDocumentationProvider {
 
   // TODO refactor with MultilineCommentDocumentationProvider
@@ -73,7 +74,7 @@ protected String getJavaDocComment(final INode node) {
     }
     if (node instanceof ILeafNode && node.getGrammarElement() instanceof TerminalRule
         && ruleName.equalsIgnoreCase(((TerminalRule) node.getGrammarElement()).getName())) {
-      String comment = ((ILeafNode) node).getText();
+      String comment = node.getText();
       if (comment.matches("(?s)" + startTag + ".*")) {
         return comment;
       }

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java

@@ -45,6 +45,7 @@
 /**
  * The Check compiler used for generating Java code from Check models.
  */
+@SuppressWarnings("nls")
 // CHECKSTYLE:CONSTANTS-OFF
 public class CheckCompiler extends XbaseCompiler {
 

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckGeneratorConstants.java

@@ -13,6 +13,7 @@
 /**
  * Generator constants.
  */
+@SuppressWarnings("nls")
 public final class CheckGeneratorConstants {
 
   public static final String CHECK_DOC_OUTPUT = "CHECK_DOC_OUTPUT";

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckOutputConfigurationProvider.java

@@ -22,6 +22,7 @@
  *
  * @see org.eclipse.xtext.generator.IFileSystemAccess
  */
+@SuppressWarnings("nls")
 public class CheckOutputConfigurationProvider extends OutputConfigurationProvider {
 
   public static final String DOCS_PATH = "docs/content";

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckPropertiesGenerator.java

@@ -22,6 +22,7 @@
 /**
  * Generates keys and values used by issue codes and check configurations.
  */
+@SuppressWarnings("nls")
 public final class CheckPropertiesGenerator {
 
   private CheckPropertiesGenerator() {

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/naming/CheckDeclarativeQualifiedNameProvider.java

@@ -30,27 +30,27 @@ public class CheckDeclarativeQualifiedNameProvider extends XbaseQualifiedNamePro
 
   /**
    * Gets the qualified name for a {@link CheckCatalog Check Catalog}.
-   * 
+   *
    * @param catalog
    *          the check catalog
    * @return the fully qualified name
    */
   QualifiedName qualifiedName(final CheckCatalog catalog) {
-    return converter.toQualifiedName(catalog.getPackageName() + "." + catalog.getName());
+    return converter.toQualifiedName(catalog.getPackageName() + '.' + catalog.getName());
   }
 
   /**
    * Creates a qualified name for a given Check instance. The first segment of the
    * qualified name corresponds to the parent catalog name.
-   * 
+   *
    * @param check
    *          the check
    * @return the qualified name
    */
   QualifiedName qualifiedName(final Check check) {
     // name of check can be null while editing
     String name = check.getName();
-    return qualifiedName(EcoreUtil2.getContainerOfType(check, CheckCatalog.class)).append(name != null ? name : "null");
+    return qualifiedName(EcoreUtil2.getContainerOfType(check, CheckCatalog.class)).append(name != null ? name : "null"); //$NON-NLS-1$
   }
 
 }

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CatalogFromExtensionPointScope.java

@@ -33,6 +33,7 @@
 /**
  * Defines a scope scope for check catalogs located in the plugin registry.
  */
+@SuppressWarnings("nls")
 public class CatalogFromExtensionPointScope extends AbstractScope {
 
   private final IModelLocation locationData;

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/scoping/CheckLinkingService.java

@@ -17,25 +17,23 @@
 import org.eclipse.xtext.conversion.IValueConverterService;
 import org.eclipse.xtext.nodemodel.INode;
 
-import com.avaloq.tools.ddk.xtext.linking.AbstractFastLinkingService;
 import com.avaloq.tools.ddk.check.check.CheckPackage;
 import com.avaloq.tools.ddk.check.services.CheckGrammarAccess;
+import com.avaloq.tools.ddk.xtext.linking.AbstractFastLinkingService;
 import com.google.inject.Inject;
 
 
 /**
  * A linking service for the Check language.
  */
+@SuppressWarnings("nls")
 public class CheckLinkingService extends AbstractFastLinkingService {
 
   @Inject
   private IValueConverterService valueConverterService;
   @Inject
   private CheckGrammarAccess grammarAccess;
 
-  /**
-   * {@inheritDoc}
-   */
   @Override
   public List<EObject> getLinkedObjects(final EObject context, final EReference ref, final INode node) {
     if (ref == CheckPackage.Literals.CHECK_CATALOG__GRAMMAR) {

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/CheckJavaValidatorUtil.java

@@ -26,6 +26,7 @@
  * and the wizards.
  */
 @Singleton
+@SuppressWarnings("nls")
 public class CheckJavaValidatorUtil {
 
   /** Two dots in a row. */

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/ClasspathBasedChecks.java

@@ -31,6 +31,7 @@
  * Largely inspired from org.eclipse.xtext.xtend2.validation.ClasspathBasedChecks.
  * TODO: This code should go in utility functions...
  */
+@SuppressWarnings("nls")
 public class ClasspathBasedChecks extends AbstractDeclarativeValidator {
 
   private static final String SLASH = "/";
@@ -44,7 +45,7 @@ public void register(final EValidatorRegistrar registrar) {
   /**
    * Verifies that a given catalog file has the same name as the name given in the model.
    * Also verifies that the given package exists and that the file is in that package.
-   * 
+   *
    * @param catalog
    *          a check catalog
    */
@@ -81,7 +82,7 @@ public void checkFileNamingConventions(final CheckCatalog catalog) {
 
   /**
    * Reports an invalid package error.
-   * 
+   *
    * @param catalog
    *          the catalog
    * @param givenPackageName

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/FormalParameterCheckBase.java

@@ -34,7 +34,7 @@ public void register(final EValidatorRegistrar registrar) {
   /**
    * Validates that all XNumberLiterals in this expression, which occurs on the right-hand side of a formal parameter
    * declaration/definition, have indeed integral values.
-   * 
+   *
    * @param value
    *          to check
    * @param issueCode
@@ -52,7 +52,7 @@ protected void checkRightHandSideHasOnlyIntegralNumbers(final XExpression value,
           try {
             Integer.decode(((XNumberLiteral) e).getValue());
           } catch (NumberFormatException ex) {
-            error("Only integral values as numbers are allowed in check parameters", expr, null, issueCode); // TODO: NLS
+            error("Only integral values as numbers are allowed in check parameters", expr, null, issueCode); // TODO: NLS //$NON-NLS-1$
           }
         }
       }

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/IssueCodes.java

@@ -13,6 +13,7 @@
 /**
  * Issue codes used for the Check Java validator.
  */
+@SuppressWarnings("nls")
 public final class IssueCodes {
   private static final String ISSUE_CODE_PREFIX = "com.avaloq.tools.ddk.check.validation.IssueCodes.";
 

com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/CheckContextTest.java

@@ -20,6 +20,7 @@
 /**
  * Provides some tests of the reflective {@link AbstractCheckContext} framework.
  */
+@SuppressWarnings("nls")
 public class CheckContextTest extends TestCase {
 
   public static final String ENABLED_ISSUE_CODE = "Enabled.Issue.Code";

com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/registry/CheckExtensionPointTests.java

@@ -27,6 +27,7 @@
 /**
  * Provides some test cases for the Check extension point.
  */
+@SuppressWarnings("nls")
 public class CheckExtensionPointTests extends TestCase {
 
   private static final String DUMMY_EXTENSION_ID = "com.avaloq.tools.ddk.check.runtime.core.test";

com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/core/validation/CheckValidatorTest.java

@@ -23,6 +23,7 @@
 /**
  * Performs some basic validation tests on the {@link AbstractCheckValidator}.
  */
+@SuppressWarnings("nls")
 public class CheckValidatorTest extends AbstractCheckValidator {
   /**
    * Represents the dummy language which is also registered in the plugin.xml.
@@ -31,7 +32,7 @@ public class CheckValidatorTest extends AbstractCheckValidator {
 
   /**
    * Returns a dummy language ID.
-   * 
+   *
    * @return the host language
    */
   @Override
@@ -41,7 +42,7 @@ protected String getHostLanguage() {
 
   /**
    * Tests that the dummy validator is found via the check validator extension point.
-   * 
+   *
    * @see {@link com.avaloq.tools.ddk.check.extensionpoint.test.validation.DummyValidator}
    */
   @Test

com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/TestLanguageUiInjectorProvider.java

@@ -11,6 +11,7 @@
 public class TestLanguageUiInjectorProvider implements IInjectorProvider {
 
   @Override
+  @SuppressWarnings("nls")
   public Injector getInjector() {
     return com.avaloq.tools.ddk.check.ui.internal.TestLanguageActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.TestLanguage");
   }

com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/test/runtime/TestLanguageUiInjectorProvider.java

@@ -12,7 +12,7 @@ public class TestLanguageUiInjectorProvider implements IInjectorProvider {
 
   @Override
   public Injector getInjector() {
-    return com.avaloq.tools.ddk.check.ui.internal.TestLanguageActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.TestLanguage");
+    return com.avaloq.tools.ddk.check.ui.internal.TestLanguageActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.TestLanguage"); //$NON-NLS-1$
   }
 
 }

com.avaloq.tools.ddk.check.test.runtime/src/com/avaloq/tools/ddk/check/validation/TestLanguageJavaValidator.java

@@ -21,6 +21,7 @@
 /**
  * The Class TestLanguageJavaValidator.
  */
+@SuppressWarnings("nls")
 public class TestLanguageJavaValidator extends AbstractTestLanguageJavaValidator {
 
   @Check

com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/CheckUiInjectorProvider.java

@@ -15,7 +15,7 @@ public class CheckUiInjectorProvider implements IInjectorProvider {
 
   @Override
   public Injector getInjector() {
-    return com.avaloq.tools.ddk.check.ui.internal.CheckActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.Check");
+    return com.avaloq.tools.ddk.check.ui.internal.CheckActivator.getInstance().getInjector("com.avaloq.tools.ddk.check.Check"); //$NON-NLS-1$
   }
 
 }

com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckCatalogWizardTest.java

@@ -54,6 +54,7 @@
  */
 @InjectWith(CheckWizardUiTestInjectorProvider.class)
 @RunWith(XtextClassRunner.class)
+@SuppressWarnings("nls")
 public class CheckCatalogWizardTest {
 
   /** This is the name of the catalog wizard. It's the name SWTBot uses to look up the wizard. */

com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckProjectWizardTest.java

@@ -34,6 +34,7 @@
  */
 @InjectWith(CheckWizardUiTestInjectorProvider.class)
 @RunWith(XtextClassRunner.class)
+@SuppressWarnings("nls")
 public class CheckProjectWizardTest {
 
   /** This is the name of the project wizard. It's the name SWTBot uses to look up the wizard. */

com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckContextsExtensionTest.java

@@ -18,9 +18,9 @@
 import org.eclipse.pde.core.plugin.IPluginExtension;
 import org.eclipse.pde.core.plugin.IPluginModelBase;
 import org.eclipse.pde.internal.core.plugin.WorkspacePluginModel;
+import org.eclipse.xtext.testing.InjectWith;
 import org.eclipse.xtext.testing.XtextRunner;
 import org.eclipse.xtext.testing.util.ParseHelper;
-import org.eclipse.xtext.testing.InjectWith;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -39,7 +39,7 @@
 /**
  * Tests CheckContextExtensionUtil.
  */
-@SuppressWarnings("restriction")
+@SuppressWarnings({"restriction", "nls"})
 @InjectWith(CheckWizardUiTestInjectorProvider.class)
 @RunWith(XtextRunner.class)
 public class CheckContextsExtensionTest extends TestCase {

com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckMarkerHelpExtensionTest.java

@@ -46,7 +46,7 @@
 /**
  * Tests the MarkerHelpExtensionUtil class.
  */
-@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException"})
+@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException", "nls"})
 @InjectWith(CheckWizardUiTestInjectorProvider.class)
 @RunWith(XtextRunner.class)
 public class CheckMarkerHelpExtensionTest {

com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/builder/CheckTocExtensionTest.java

@@ -10,8 +10,6 @@
  *******************************************************************************/
 package com.avaloq.tools.ddk.check.ui.test.builder;
 
-import junit.framework.TestCase;
-
 import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IWorkspace;
 import org.eclipse.core.runtime.CoreException;
@@ -35,11 +33,13 @@
 import com.google.common.collect.Lists;
 import com.google.inject.Inject;
 
+import junit.framework.TestCase;
+
 
 /**
  * Tests the CheckTocExtensionUtil class.
  */
-@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException"})
+@SuppressWarnings({"restriction", "PMD.SignatureDeclareThrowsException", "nls"})
 @InjectWith(CheckWizardUiTestInjectorProvider.class)
 @RunWith(XtextRunner.class)
 public class CheckTocExtensionTest extends TestCase {
@@ -69,7 +69,7 @@ public void setUp() throws Exception {
 
   /**
    * Tests if the toc extension is correctly created.
-   * 
+   *
    * @throws CoreException
    *           the core exception
    */
@@ -84,7 +84,7 @@ public void testCreateExtension() throws CoreException {
 
   /**
    * Tests if isExtensionUpdateRequired returns true if only an erroneous extension exists for the check catalog.
-   * 
+   *
    * @throws CoreException
    *           the core exception
    */
@@ -98,7 +98,7 @@ public void testIsExtensionUpdateRequiredTrue() throws CoreException {
 
   /**
    * Creates an erroneous toc extension.
-   * 
+   *
    * @return the plugin extension
    * @throws CoreException
    *           the core exception
@@ -116,7 +116,7 @@ private IPluginExtension createErroneousTocExtension() throws CoreException {
 
   /**
    * Tests if an update of a toc extension is correctly done.
-   * 
+   *
    * @throws CoreException
    *           the core exception
    */
@@ -130,7 +130,7 @@ public void testUpdateTocExtension() throws CoreException {
 
   /**
    * Tests if isExtensionUpdateRequires returns false if a correct extension already exists.
-   * 
+   *
    * @throws CoreException
    *           the core exception
    */