feat: run the tests on junit5 platform using junit-vintage-engine#1183
Closed
markdomeng wants to merge 2 commits into
Closed
feat: run the tests on junit5 platform using junit-vintage-engine#1183markdomeng wants to merge 2 commits into
markdomeng wants to merge 2 commits into
Conversation
use junit-vintage-engine to support junit4 tests
use junit vintage engine to run junit4 tests
rubenporras
reviewed
Oct 14, 2025
| <booleanAttribute key="useDefaultConfig" value="true"/> | ||
| <booleanAttribute key="useDefaultConfigArea" value="false"/> | ||
| <booleanAttribute key="useProduct" value="true"/> | ||
| <booleanAttribute key="append.args" value="true"/> |
Member
There was a problem hiding this comment.
Can we improve the order and the indentation in this an other files to make the diff smaller?
rubenporras
requested changes
Oct 14, 2025
Member
rubenporras
left a comment
rubenporras
left a comment
There was a problem hiding this comment.
See comment on the launch files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.