Skip to content

chore: bump PMD to v7.17.0 in GitHub actions #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaodinissf wants to merge 2 commits into from
Closed

chore: bump PMD to v7.17.0 in GitHub actions #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ba2980
fix: fix Check UI tests
joaodinissf Sep 19, 2025
3826669
chore: bump PMD to v7.17.0 in GitHub actions
joaodinissf Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
uses: pmd/pmd-github-action@v2.0.0
id: pmd
with:
version: '7.15.0'
version: '7.17.0'
rulesets: 'ddk-configuration/pmd/ruleset.xml'
analyzeModifiedFilesOnly: false
- name: Fail build if there are violations
Expand Down
1 change: 1 addition & 0 deletions ...ools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckCatalogWizardTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
*/
@InjectWith(CheckWizardUiTestInjectorProvider.class)
@RunWith(XtextClassRunner.class)
@SuppressWarnings("nls")
public class CheckCatalogWizardTest {

/** This is the name of the catalog wizard. It's the name SWTBot uses to look up the wizard. */
Expand Down
1 change: 1 addition & 0 deletions com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
/**
* Extended {@link SWTWorkbenchBot}.
*/
@SuppressWarnings("nls")
public class SwtWorkbenchBot extends SWTWorkbenchBot {
private static final int DELAY_WIZARD_PAGE = 1000;
private static final String TIMEOUT_MSG = "Timeout of {0} ms reached while waiting for Button {1} to become active";
Expand Down
8 changes: 8 additions & 0 deletions ...aloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotWizardUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
/**
* Utility class for selection methods in an eclipse widget for SWTBot testing.
*/
@SuppressWarnings("nls")
public final class SwtBotWizardUtil {

private SwtBotWizardUtil() {
Expand All @@ -41,6 +42,13 @@ private SwtBotWizardUtil() {
* the folder name
*/
public static void selectProjectFolder(final SwtWorkbenchBot bot, final String folderName) {
// try {
// bot.viewById("org.eclipse.jdt.ui.PackageExplorer");
// } catch (WidgetNotFoundException e) {
// // If view not found, open it via menu
// bot.menu("Window").menu("Show View").menu("Package Explorer").click();
// }
// SWTBotView packageExplorer = bot.viewById("org.eclipse.jdt.ui.PackageExplorer");
SWTBotView packageExplorer = bot.viewByTitle("Project Explorer");
packageExplorer.show();
Composite comp = (Composite) packageExplorer.getWidget();
Expand Down
3 changes: 2 additions & 1 deletion ddk-target/ddk.target
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?>
<target name="DDK Target" sequenceNumber="24">
<target name="DDK Target" sequenceNumber="25">
<locations>
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="0.0.0"/>
Expand All @@ -14,6 +14,7 @@
<unit id="org.eclipse.jdt.source.feature.group" version="0.0.0"/>
<unit id="org.eclipse.platform.feature.group" version="0.0.0"/>
<unit id="org.eclipse.platform.source.feature.group" version="0.0.0"/>
<unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
<repository location="https://download.eclipse.org/eclipse/updates/4.34/"/>
</location>
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
Expand Down