Skip to content

feat: allow pinning new resource desc. in ResourceDescriptionDelta #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ava-fred merged 1 commit into from
May 9, 2025
Merged

feat: allow pinning new resource desc. in ResourceDescriptionDelta #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...loq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDelta.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public String apply(final IEObjectDescription from) {
private final URI uri;
private IResourceDescription oldDesc;
private final SoftReference<IResourceDescription> newDesc;
private IResourceDescription pinnedNewDesc;
private final IResourceDescriptions index;

private Boolean hasChanges;
Expand Down Expand Up @@ -98,6 +99,9 @@ public IResourceDescription getNew() {
if (newDesc == null) {
return null;
}
if (pinnedNewDesc != null) {
return pinnedNewDesc;
}
IResourceDescription res = newDesc.get();
return res != null ? res : index.getResourceDescription(uri);
}
Expand Down Expand Up @@ -127,6 +131,20 @@ public boolean haveEObjectDescriptionsChanged() {
return hasChanges;
}

/**
* Ensure the new resource description is not touched by GC.
*/
public void pinNew() {
pinnedNewDesc = newDesc == null ? null : newDesc.get();
}

/**
* Reverse the effect of {@link pinNew}.
*/
public void unpinNew() {
pinnedNewDesc = null;
}

/**
* Discards the old descriptions as it's either equivalent to the new or can be computed from a diff against the new.
*
Expand Down