fix: load model when loading model associations.#1120
Merged
Conversation
The model associations are persisted as relations between model elements, so the model must exist when the associations are loaded from binary storage.
rubenporras
reviewed
Apr 29, 2025
| DirectLinkingResourceStorageLoadable loadable = (DirectLinkingResourceStorageLoadable) ((DirectLinkingResourceStorageFacade) resource.getResourceStorageFacade()).getOrCreateResourceStorageLoadable(resource); | ||
| try { | ||
| // the associations are mappings from AST model elements to inferred model elements (and back) so we cannot skip loading the model. | ||
| ResourceSetOptions.setSkipModel(resource.getResourceSet(), false); |
Collaborator
Author
There was a problem hiding this comment.
I don't think so. Isn't this just a load that was missed when the 'skipModel' option was added?
Member
There was a problem hiding this comment.
but that is a programming error, isn't it?
rubenporras
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model associations are persisted as relations between model elements, so the model must exist when the associations are loaded from binary storage.