Skip to content

Please consider the following formatting changes to #13182 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsekihat merged 1 commit into from
Sep 30, 2025
Merged

Please consider the following formatting changes to #13182 #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PWGEM/PhotonMeson/Core/V0PhotonCut.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.

Check failure on line 11 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \author is missing, incorrect or misplaced.

Check failure on line 11 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.

Check failure on line 11 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.
//
// Class for v0 photon selection
//
Expand All @@ -28,7 +28,7 @@
#include <string>
#include <utility>
#include <vector>
using namespace o2::pwgem::photonmeson;

Check failure on line 31 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[using-directive] 

Do not put using directives at global scope in headers.

class V0PhotonCut : public TNamed
{
Expand Down Expand Up @@ -128,7 +128,7 @@
auto pos = v0.template posTrack_as<TLeg>();
auto ele = v0.template negTrack_as<TLeg>();

for (auto& track : {pos, ele}) {

Check failure on line 131 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (!IsSelectedTrack(track, V0PhotonCuts::kTrackPtRange)) {
return false;
}
Expand Down Expand Up @@ -255,7 +255,7 @@
return v0.mGamma() < mMaxQt * 2.f;

case V0PhotonCuts::kAP:
return pow(v0.alpha() / mMaxAlpha, 2) + pow(v0.qtarm() / mMaxQt, 2) < 1.0;

Check failure on line 258 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.

case V0PhotonCuts::kPsiPair:
return true;
Expand Down Expand Up @@ -293,17 +293,17 @@
float y = v0.vy(); // cm, measured secondary vertex of gamma->ee
float z = v0.vz(); // cm, measured secondary vertex of gamma->ee

float rxy = sqrt(x * x + y * y);

Check failure on line 296 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
if (rxy < 7.0 || 14.0 < rxy) {

Check failure on line 297 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}

// r = 0.192 * z + 8.88 (cm) expected wire position in RZ plane.TMath::Tan(10.86 * TMath::DegToRad()) = 0.192
if (rxy > 0.192 * z + 14.0) { // upper limit

Check failure on line 302 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}

float dxy = std::fabs(1.0 * y - x * std::tan(-8.52 * TMath::DegToRad())) / sqrt(pow(1.0, 2) + pow(std::tan(-8.52 * TMath::DegToRad()), 2));

Check failure on line 306 in PWGEM/PhotonMeson/Core/V0PhotonCut.h

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
return !(dxy > margin_xy);
}
case V0PhotonCuts::kOnWwireOB: {
Expand Down Expand Up @@ -359,8 +359,8 @@
case V0PhotonCuts::kTPCNsigmaEl:
return track.tpcNSigmaEl() > mMinTPCNsigmaEl && track.tpcNSigmaEl() < mMaxTPCNsigmaEl;

// case V0PhotonCuts::kTPCNsigmaPi:
// return track.tpcNSigmaPi() > mMinTPCNsigmaPi && track.tpcNSigmaPi() < mMaxTPCNsigmaPi;
// case V0PhotonCuts::kTPCNsigmaPi:
// return track.tpcNSigmaPi() > mMinTPCNsigmaPi && track.tpcNSigmaPi() < mMaxTPCNsigmaPi;

case V0PhotonCuts::kDCAxy:
return std::fabs(track.dcaXY()) < ((mMaxDcaXYPtDep) ? mMaxDcaXYPtDep(track.pt()) : mMaxDcaXY);
Expand Down
Loading