Support root commands that doesn't implement call#135
Conversation
| end | ||
| end | ||
|
|
||
| class Namespace < Dry::CLI::Command |
There was a problem hiding this comment.
Isn't bizarre to have a "command" that the uniq usage is to print top level usage? I am wondering if it should be a better idea to move the usage of top class as specific dsl. Like suggested here #96 ?
There was a problem hiding this comment.
It is. I tried to implement the suggestion from #96, but I couldn't figure out how to do it. Maybe we can create the Dry::CLI::Namespace class, so It will look less strange.
There was a problem hiding this comment.
@gustavothecoder I like the idea of this being a specialised Namespace class. That way, when the class is used, it will be clearer that its purpose is to provide information about a grouping of subcommands only, and not its own distinct command behaviour.
I prefer this help text residing in a concrete class instead of being part of the top-level command registration API, since that feels more consistent with how the rest of the CLI construction is done: a class for each thing.
If you're still interested in working on this PR, I'd love it if you could make this adjustment! Let me know what you think.
There was a problem hiding this comment.
@timriley Done! I think it looks better using the Namespace class.
|
This is a great proposal. I would love to be able to use this in our CLI. |
6163287 to
3b16959
Compare
|
Hi @gustavothecoder!! Happy new year :) Firstly, I want to apologise for the delay in attending to all your excellent PRs. Good news, though — in January we'll be focusing on getting a new dry-cli shipped with all your work incorporated. We'll be back in touch in the PRs. Thank you for your contributions! |
3b16959 to
16fb4f7
Compare
|
Thanks a lot @katafrakt |
Resolve #96
I would like to add descriptions to my root commands without implementing a proper command, like a namespace.
Example
Command
Result