Open
Conversation
This commit adds a new kind of `redis.node.type`, `uri`, which takes a Lettuce Redis URI [^1]. The existing connection types expect `host:port` pairs, not absolute URIs, and take additional options as separate fields. Since Redis URIs can specify all these options as query params, the new `uri` type takes just the URI. Closes dropwizard#60. [^1]: https://redis.github.io/lettuce/user-guide/connecting-redis
Author
|
I dropped a quick note about my use case here! I'd be happy to change anything in the PR—I'm a newcomer to Dropwizard and the Java web services world in general—and I also have a workaround, so there's no pressure to merge it if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new kind of
redis.node.type,uri, which takes a Lettuce Redis URI 1. The existing connection types expecthost:portpairs, not absolute URIs, and take additional options as separate fields. Since Redis URIs can specify all these options as query params, the newuritype takes just the URI.Closes #60.
Footnotes
https://redis.github.io/lettuce/user-guide/connecting-redis ↩